Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(382)

Issue 2510123002: Remove the CFWL_EventType::DrawItem (Closed)

Created:
4 years, 1 month ago by dsinclair
Modified:
4 years, 1 month ago
Reviewers:
Tom Sepez, npm
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Remove the CFWL_EventType::DrawItem The ListBox DrawItems event is caught by the ComboBox which converts the event into a ComboBox DrawItems event which is never processed. Removed both. Committed: https://pdfium.googlesource.com/pdfium/+/28f9b62c397c4f3f8dc0cba69ce1cb8c02f81e76

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -35 lines) Patch
M xfa/fwl/core/cfwl_event.h View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/fwl/core/ifwl_combobox.h View 1 chunk +0 lines, -7 lines 0 comments Download
M xfa/fwl/core/ifwl_combobox.cpp View 1 chunk +1 line, -10 lines 0 comments Download
M xfa/fwl/core/ifwl_listbox.h View 1 chunk +0 lines, -7 lines 0 comments Download
M xfa/fwl/core/ifwl_listbox.cpp View 1 chunk +1 line, -10 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 11 (7 generated)
dsinclair
PTAL.
4 years, 1 month ago (2016-11-17 16:54:40 UTC) #2
Tom Sepez
lgtm
4 years, 1 month ago (2016-11-17 17:13:41 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2510123002/1
4 years, 1 month ago (2016-11-17 17:55:25 UTC) #9
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 17:55:44 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/28f9b62c397c4f3f8dc0cba69ce1cb8c02f8...

Powered by Google App Engine
This is Rietveld 408576698