Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2114)

Unified Diff: content/renderer/media/rtc_peer_connection_handler_unittest.cc

Issue 2511633002: Rename "updateICE" to "setConfiguration", everywhere except in Blink. (Closed)
Patch Set: Making sure updateIce doesn't change behavior in this CL. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/media/rtc_peer_connection_handler_unittest.cc
diff --git a/content/renderer/media/rtc_peer_connection_handler_unittest.cc b/content/renderer/media/rtc_peer_connection_handler_unittest.cc
index 8cb640a16abf5c8ccc504536334e47e353d7819a..29751d329e1d39b51ba9b1bff02916f7991d1bf7 100644
--- a/content/renderer/media/rtc_peer_connection_handler_unittest.cc
+++ b/content/renderer/media/rtc_peer_connection_handler_unittest.cc
@@ -149,7 +149,7 @@ class MockPeerConnectionTracker : public PeerConnectionTracker {
const std::string& sdp, const std::string& type,
Source source));
MOCK_METHOD2(
- TrackUpdateIce,
+ TrackSetConfiguration,
void(RTCPeerConnectionHandler* pc_handler,
const webrtc::PeerConnectionInterface::RTCConfiguration& config));
MOCK_METHOD4(TrackAddIceCandidate,
@@ -506,14 +506,15 @@ TEST_F(RTCPeerConnectionHandlerTest, setRemoteDescription) {
EXPECT_EQ(kDummySdp, sdp_string);
}
-TEST_F(RTCPeerConnectionHandlerTest, updateICE) {
+TEST_F(RTCPeerConnectionHandlerTest, setConfiguration) {
blink::WebRTCConfiguration config;
- EXPECT_CALL(*mock_tracker_.get(), TrackUpdateIce(pc_handler_.get(), _));
+ EXPECT_CALL(*mock_tracker_.get(),
+ TrackSetConfiguration(pc_handler_.get(), _));
// TODO(perkj): Test that the parameters in |config| can be translated when a
// WebRTCConfiguration can be constructed. It's WebKit class and can't be
// initialized from a test.
- EXPECT_TRUE(pc_handler_->updateICE(config));
+ EXPECT_TRUE(pc_handler_->setConfiguration(config));
}
TEST_F(RTCPeerConnectionHandlerTest, addICECandidate) {

Powered by Google App Engine
This is Rietveld 408576698