Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2851)

Unified Diff: third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp

Issue 2511633002: Rename "updateICE" to "setConfiguration", everywhere except in Blink. (Closed)
Patch Set: Removing the IDL changes from this CL. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp
diff --git a/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp b/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp
index 79f35a22693a050135726de006be5a2fbaca6f97..21a2e7a1bb666f3ce91b1f6105c1e56d47172ddc 100644
--- a/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp
+++ b/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp
@@ -798,10 +798,11 @@ RTCSessionDescription* RTCPeerConnection::remoteDescription() {
return RTCSessionDescription::create(webSessionDescription);
}
-void RTCPeerConnection::updateIce(ExecutionContext* context,
- const RTCConfiguration& rtcConfiguration,
- const Dictionary& mediaConstraints,
- ExceptionState& exceptionState) {
+void RTCPeerConnection::setConfiguration(
+ ExecutionContext* context,
+ const RTCConfiguration& rtcConfiguration,
+ const Dictionary& mediaConstraints,
foolip 2016/11/18 08:56:05 Remove the argument name to make it obvious that i
Taylor_Brandstetter 2016/11/18 20:07:56 Done.
+ ExceptionState& exceptionState) {
if (throwExceptionIfSignalingStateClosed(m_signalingState, exceptionState))
return;
@@ -818,12 +819,12 @@ void RTCPeerConnection::updateIce(ExecutionContext* context,
return;
}
- // Constraints are ignored.
- bool valid = m_peerHandler->updateICE(configuration);
- if (!valid)
+ bool valid = m_peerHandler->setConfiguration(configuration);
+ if (!valid) {
exceptionState.throwDOMException(
SyntaxError,
- "Could not update the ICE Agent with the given configuration.");
+ "Could not update the RTCPeerConnection with the given configuration.");
+ }
}
ScriptPromise RTCPeerConnection::generateCertificate(

Powered by Google App Engine
This is Rietveld 408576698