third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.idl - Issue 2511633002: Rename "updateICE" to "setConfiguration", everywhere except in Blink.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.idl

Issue 2511633002: Rename "updateICE" to "setConfiguration", everywhere except in Blink. (Closed)

Patch Set: Removing the IDL changes from this CL. Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp ('K') | « third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp ('k') | third_party/WebKit/public/platform/WebRTCPeerConnectionHandler.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.idl

diff --git a/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.idl b/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.idl

index 2e48d3ee8ebb1883df9c06a7b7a5a0cc86617bbb..dab6bcfe508a681e57c7d4a53bacf5f71304101b 100644

--- a/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.idl

+++ b/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.idl

@@ -120,7 +120,7 @@ enum RTCIceConnectionState {

[RaisesException, CallWith=ScriptState] static Promise<RTCCertificate> generateCertificate(AlgorithmIdentifier keygenAlgorithm);

// Non-standard or removed from the spec:

- [Measure, CallWith=ExecutionContext, RaisesException] void updateIce(optional RTCConfiguration configuration, optional Dictionary mediaConstraints);

+ [Measure, CallWith=ExecutionContext, ImplementedAs=setConfiguration, RaisesException] void updateIce(optional RTCConfiguration configuration, optional Dictionary mediaConstraints);

[Measure] sequence<MediaStream> getLocalStreams();

[Measure] sequence<MediaStream> getRemoteStreams();

[Measure] MediaStream getStreamById(DOMString streamId);