Rename "updateICE" to "setConfiguration", everywhere except in Blink.

third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 780 matching lines @@
 
 RTCSessionDescription* RTCPeerConnection::remoteDescription() {
   WebRTCSessionDescription webSessionDescription =
       m_peerHandler->remoteDescription();
   if (webSessionDescription.isNull())
     return nullptr;
 
   return RTCSessionDescription::create(webSessionDescription);
 }
 
-void RTCPeerConnection::updateIce(ExecutionContext* context,
-                                  const RTCConfiguration& rtcConfiguration,
-                                  const Dictionary& mediaConstraints,
-                                  ExceptionState& exceptionState) {
+void RTCPeerConnection::setConfiguration(
+    ExecutionContext* context,
+    const RTCConfiguration& rtcConfiguration,
+    const Dictionary& mediaConstraints,

[foolip, 2016/11/18 08:56:05]

Remove the argument name to make it obvious that it's unused. (Removing it from
the IDL would be observable in a very small way, so probably clean do that when
removing updateIce.)

[Taylor_Brandstetter, 2016/11/18 20:07:56]

Done.

+    ExceptionState& exceptionState) {
   if (throwExceptionIfSignalingStateClosed(m_signalingState, exceptionState))
     return;
 
   RtcpMuxPolicy selectedRtcpMuxPolicy = RtcpMuxPolicyDefault;
   WebRTCConfiguration configuration = parseConfiguration(
       context, rtcConfiguration, exceptionState, &selectedRtcpMuxPolicy);
 
   if (exceptionState.hadException())
     return;
 
   MediaErrorState mediaErrorState;
   if (mediaErrorState.hadException()) {
     mediaErrorState.raiseException(exceptionState);
     return;
   }
 
-  // Constraints are ignored.
-  bool valid = m_peerHandler->updateICE(configuration);
-  if (!valid)
+  bool valid = m_peerHandler->setConfiguration(configuration);
+  if (!valid) {
     exceptionState.throwDOMException(
         SyntaxError,
-        "Could not update the ICE Agent with the given configuration.");
+        "Could not update the RTCPeerConnection with the given configuration.");
+  }
 }
 
 ScriptPromise RTCPeerConnection::generateCertificate(
     ScriptState* scriptState,
     const AlgorithmIdentifier& keygenAlgorithm,
     ExceptionState& exceptionState) {
   // Normalize |keygenAlgorithm| with WebCrypto, making sure it is a recognized
   // AlgorithmIdentifier.
   WebCryptoAlgorithm cryptoAlgorithm;
   AlgorithmError error;
@@ skipping 642 matching lines @@
 DEFINE_TRACE(RTCPeerConnection) {
   visitor->trace(m_localStreams);
   visitor->trace(m_remoteStreams);
   visitor->trace(m_dispatchScheduledEventRunner);
   visitor->trace(m_scheduledEvents);
   EventTargetWithInlineData::trace(visitor);
   ActiveDOMObject::trace(visitor);
 }
 
 }  // namespace blink