Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 2511493002: Revert of Implement THROTTLED priority semantics. (Closed)

Created:
4 years, 1 month ago by Randy Smith (Not in Mondays)
Modified:
4 years, 1 month ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, kinuko
Base URL:
https://chromium.googlesource.com/chromium/src.git@NetworkStreamThrottler
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Implement THROTTLED priority semantics. (patchset #54 id:1090001 of https://codereview.chromium.org/2130493002/ ) Reason for revert: Crash on Android Cronet Lollipop bots. Original issue's description: > Implement THROTTLED priority semantics. > > BUG=600839 > R=mmenke@chromium.org > > Committed: https://crrev.com/a3ea24ae1987d24b536859dad3d18537dd917242 > Cr-Commit-Position: refs/heads/master@{#432558} TBR=mmenke@chromium.org,csharrison@chromium.org,rsleevi@chromium.org,yfriedman@chromium.org,tedchoc@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=600839 Committed: https://crrev.com/62767ec185ed08d25b60402c8c848d935da40d43 Cr-Commit-Position: refs/heads/master@{#432585}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -1802 lines) Patch
M content/browser/android/url_request_content_job_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/base/network_throttle_manager.h View 4 chunks +12 lines, -15 lines 0 comments Download
D net/base/network_throttle_manager_impl.h View 1 chunk +0 lines, -152 lines 0 comments Download
D net/base/network_throttle_manager_impl.cc View 1 chunk +0 lines, -326 lines 0 comments Download
D net/base/network_throttle_manager_impl_unittest.cc View 1 chunk +0 lines, -568 lines 0 comments Download
D net/base/percentile_estimator.h View 1 chunk +0 lines, -59 lines 0 comments Download
D net/base/percentile_estimator.cc View 1 chunk +0 lines, -100 lines 0 comments Download
D net/base/percentile_estimator_unittest.cc View 1 chunk +0 lines, -242 lines 0 comments Download
M net/http/http_network_session.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/http/http_network_transaction.h View 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_network_transaction.cc View 3 chunks +4 lines, -6 lines 0 comments Download
M net/http/http_network_transaction_unittest.cc View 3 chunks +3 lines, -7 lines 0 comments Download
M net/net.gypi View 2 chunks +2 lines, -6 lines 0 comments Download
M net/url_request/url_request_unittest.cc View 12 chunks +5 lines, -318 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Randy Smith (Not in Mondays)
Created Revert of Implement THROTTLED priority semantics.
4 years, 1 month ago (2016-11-16 19:17:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2511493002/1
4 years, 1 month ago (2016-11-16 19:18:59 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-16 19:20:23 UTC) #5
commit-bot: I haz the power
4 years, 1 month ago (2016-11-16 19:53:32 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/62767ec185ed08d25b60402c8c848d935da40d43
Cr-Commit-Position: refs/heads/master@{#432585}

Powered by Google App Engine
This is Rietveld 408576698