Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(505)

Unified Diff: net/http/http_network_transaction_unittest.cc

Issue 2511493002: Revert of Implement THROTTLED priority semantics. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@NetworkStreamThrottler
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/http/http_network_transaction.cc ('k') | net/net.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/http_network_transaction_unittest.cc
diff --git a/net/http/http_network_transaction_unittest.cc b/net/http/http_network_transaction_unittest.cc
index d98e9eabcfb59c3ef96a8651b08bdd3ad0922c1e..f4ab0aad04960bf87a6afb3a4093e03e6448c9e9 100644
--- a/net/http/http_network_transaction_unittest.cc
+++ b/net/http/http_network_transaction_unittest.cc
@@ -135,7 +135,7 @@
void UnthrottleAllRequests() {
std::set<TestThrottle*> outstanding_throttles_copy(outstanding_throttles_);
for (auto& throttle : outstanding_throttles_copy) {
- if (throttle->IsBlocked())
+ if (throttle->IsThrottled())
throttle->Unthrottle();
}
}
@@ -162,11 +162,7 @@
~TestThrottle() override { throttler_->OnThrottleDestroyed(this); }
// Throttle
- bool IsBlocked() const override { return throttled_; }
- RequestPriority Priority() const override {
- NOTREACHED();
- return IDLE;
- }
+ bool IsThrottled() const override { return throttled_; }
void SetPriority(RequestPriority priority) override {
throttler_->SetPriorityCalled(priority);
}
@@ -180,7 +176,7 @@
EXPECT_TRUE(throttled_);
throttled_ = false;
- delegate_->OnThrottleUnblocked(this);
+ delegate_->OnThrottleStateChanged();
}
bool throttled_;
« no previous file with comments | « net/http/http_network_transaction.cc ('k') | net/net.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698