Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 2511443002: Autodisplay android_devices when appropriate (Closed)

Created:
4 years, 1 month ago by kjlubick
Modified:
4 years, 1 month ago
Reviewers:
KevinL, jcgregorio, stephana
CC:
chromium-reviews, infra-reviews+luci-py_chromium.org, M-A Ruel
Target Ref:
refs/heads/master
Project:
luci-py
Visibility:
Public.

Description

Autodisplay android_devices when appropriate Also make device_os a bit more useful by showing full build on parent bot. BUG=665435 Committed: https://github.com/luci/luci-py/commit/dab0a559483acd249acfaca8bdb2543b731f722d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -4 lines) Patch
M appengine/swarming/ui/build/elements.html View 4 chunks +27 lines, -2 lines 0 comments Download
M appengine/swarming/ui/res/imp/botlist/bot-list.html View 4 chunks +26 lines, -1 line 0 comments Download
M appengine/swarming/ui/res/imp/common/query-column-filter-behavior.html View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 16 (9 generated)
kjlubick
live on https://2486-c9f08e9-tainted-kjlubick-dot-chromium-swarm-dev.appspot.com/botlist demo: https://screencast.googleplex.com/cast/NTY5NDAwNTgxNTgwMzkwNHxmMTkxMDY5ZS00Yg
4 years, 1 month ago (2016-11-16 18:01:18 UTC) #2
kjlubick
live on https://2486-c9f08e9-tainted-kjlubick-dot-chromium-swarm-dev.appspot.com/botlist demo: https://screencast.googleplex.com/cast/NTY5NDAwNTgxNTgwMzkwNHxmMTkxMDY5ZS00Yg
4 years, 1 month ago (2016-11-16 18:02:20 UTC) #7
kjlubick
4 years, 1 month ago (2016-11-17 19:52:00 UTC) #9
stephana
On 2016/11/17 19:52:00, kjlubick wrote: lgtm
4 years, 1 month ago (2016-11-17 19:55:37 UTC) #10
KevinL
lgtm
4 years, 1 month ago (2016-11-17 19:56:21 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2511443002/1
4 years, 1 month ago (2016-11-17 19:56:29 UTC) #14
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 20:00:27 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/luci/luci-py/commit/dab0a559483acd249acfaca8bdb2543b731f722d

Powered by Google App Engine
This is Rietveld 408576698