Finishing API error processing, and cleanup

Finishing API error processing, and cleanup.
The cleanup includes:
* Getting rid of callback param to tasks
* Getting rid of debugSetStepName

BUG=164227
TEST=No

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=228089

[robliao, 2013-09-27 20:44:16]

https://codereview.chromium.org/25114002/diff/9001/chrome/browser/resources/g...
File chrome/browser/resources/google_now/background.js (right):

https://codereview.chromium.org/25114002/diff/9001/chrome/browser/resources/g...
chrome/browser/resources/google_now/background.js:1010:
setShouldPollCards(shouldPollCards);
We should still have some sort of ordering here.

As intended, setToastVisible needs to finish before calling setShouldPollCards.
As written, either can complete in any order. When we have outgoing async calls
to different APIs, they can complete in any order as well.

[vadimt, 2013-09-27 21:10:49]

https://codereview.chromium.org/25114002/diff/9001/chrome/browser/resources/g...
File chrome/browser/resources/google_now/background.js (right):

https://codereview.chromium.org/25114002/diff/9001/chrome/browser/resources/g...
chrome/browser/resources/google_now/background.js:1010:
setShouldPollCards(shouldPollCards);
> setToastVisible needs to finish before calling setShouldPollCards.
What will happen otherwise?

[robliao, 2013-09-27 21:19:16]

https://codereview.chromium.org/25114002/diff/9001/chrome/browser/resources/g...
File chrome/browser/resources/google_now/background.js (right):

https://codereview.chromium.org/25114002/diff/9001/chrome/browser/resources/g...
chrome/browser/resources/google_now/background.js:1010:
setShouldPollCards(shouldPollCards);
We would get cards and then the welcome, or sometimes we would get the welcome
and then the cards.
On 2013/09/27 21:10:49, vadimt wrote:
> > setToastVisible needs to finish before calling setShouldPollCards.
> What will happen otherwise?

[vadimt, 2013-09-30 17:14:40]

https://codereview.chromium.org/25114002/diff/9001/chrome/browser/resources/g...
File chrome/browser/resources/google_now/background.js (right):

https://codereview.chromium.org/25114002/diff/9001/chrome/browser/resources/g...
chrome/browser/resources/google_now/background.js:1010:
setShouldPollCards(shouldPollCards);
On 2013/09/27 21:19:16, Robert Liao wrote:
> We would get cards and then the welcome, or sometimes we would get the welcome
> and then the cards.
> On 2013/09/27 21:10:49, vadimt wrote:
> > > setToastVisible needs to finish before calling setShouldPollCards.
> > What will happen otherwise?
> 

Given the temporary nature of this toast, wouldn't this be OK?
Please also note that as implemented now, cards get retrieved in its own task,
which cannot overlap with this one and will strictly be executed afterwards.
I suggest not adding complexity with callback now, when it's not necessary. We
can always do this when it becomes needed. Would this be OK?

[robliao, 2013-09-30 20:05:07]

https://codereview.chromium.org/25114002/diff/9001/chrome/browser/resources/g...
File chrome/browser/resources/google_now/background.js (right):

https://codereview.chromium.org/25114002/diff/9001/chrome/browser/resources/g...
chrome/browser/resources/google_now/background.js:1010:
setShouldPollCards(shouldPollCards);
This isn't really getting added. This CL removes this callback.

Is the whole task system okay with this? What does it do to determine that a
task has finished without a callback?
On 2013/09/30 17:14:40, vadimt wrote:
> On 2013/09/27 21:19:16, Robert Liao wrote:
> > We would get cards and then the welcome, or sometimes we would get the
welcome
> > and then the cards.
> > On 2013/09/27 21:10:49, vadimt wrote:
> > > > setToastVisible needs to finish before calling setShouldPollCards.
> > > What will happen otherwise?
> > 
> 
> Given the temporary nature of this toast, wouldn't this be OK?
> Please also note that as implemented now, cards get retrieved in its own task,
> which cannot overlap with this one and will strictly be executed afterwards.
> I suggest not adding complexity with callback now, when it's not necessary. We
> can always do this when it becomes needed. Would this be OK?

[vadimt, 2013-09-30 20:42:14]

https://codereview.chromium.org/25114002/diff/9001/chrome/browser/resources/g...
File chrome/browser/resources/google_now/background.js (right):

https://codereview.chromium.org/25114002/diff/9001/chrome/browser/resources/g...
chrome/browser/resources/google_now/background.js:1010:
setShouldPollCards(shouldPollCards);
You basically don't need to wait till the callback happens. The one who calls an
API first, wins.
The next call to the same API (chrome.notifications) will go through the same
stages (sending between processes, threads), so it will show the notification
after the the one created by the first call.

So, it's OK to finish a task without waiting for all callbacks to complete.

[robliao, 2013-09-30 22:46:31]

lgtm

[rgustafson, 2013-10-01 00:49:53]

lgtm

[skare_, 2013-10-08 21:02:32]

lgtm

[commit-bot: I haz the power, 2013-10-10 14:59:16]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a lowly provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[commit-bot: I haz the power, 2013-10-11 00:44:07]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/vadimt@chromium.org/25114002/31001

[commit-bot: I haz the power, 2013-10-11 03:08:19]

Change committed as 228089