Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(995)

Unified Diff: chrome/browser/resources/google_now/utility.js

Issue 25114002: Finishing API error processing, and cleanup (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/google_now/utility.js
diff --git a/chrome/browser/resources/google_now/utility.js b/chrome/browser/resources/google_now/utility.js
index a6436c70117d722d14c3c11a8dd782e25bfcef6d..a8e96d7d69d87cf6761d0c9b74f08da8a5c41385 100644
--- a/chrome/browser/resources/google_now/utility.js
+++ b/chrome/browser/resources/google_now/utility.js
@@ -396,7 +396,7 @@ function buildTaskManager(areConflicting) {
/**
* Queue of scheduled tasks. The first element, if present, corresponds to the
* currently running task.
- * @type {Array.<Object.<string, function(function())>>}
+ * @type {Array.<Object.<string, function()>>}
*/
var queue = [];
@@ -430,7 +430,7 @@ function buildTaskManager(areConflicting) {
var entry = queue[0];
console.log('Starting task ' + entry.name);
- entry.task(function() {}); // TODO(vadimt): Don't pass parameter.
+ entry.task();
verify(isInTask, 'startFirst: not in task at exit');
isInTask = false;
@@ -460,8 +460,7 @@ function buildTaskManager(areConflicting) {
* If any task in the queue is not compatible with the task, ignores the new
* task. Otherwise, stores the task for future execution.
* @param {string} taskName Name of the task.
- * @param {function(function())} task Function to run. Takes a callback
- * parameter. Call this callback on completion.
+ * @param {function()} task Function to run.
*/
function add(taskName, task) {
wrapper.checkInWrappedCallback();
@@ -537,8 +536,7 @@ function buildTaskManager(areConflicting) {
});
return {
- add: add,
- debugSetStepName: function() {} // TODO(vadimt): remove
+ add: add
};
}
« no previous file with comments | « chrome/browser/resources/google_now/cards.js ('k') | chrome/browser/resources/google_now/utility_unittest.gtestjs » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698