chrome/browser/resources/google_now/cards.js - Issue 25114002: Finishing API error processing, and cleanup

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/google_now/cards.js

Issue 25114002: Finishing API error processing, and cleanup (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebase Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/resources/google_now/cards.js

diff --git a/chrome/browser/resources/google_now/cards.js b/chrome/browser/resources/google_now/cards.js

index 393c8aea6c9758b6f1674433aa9eef30af4305cb..837d2b91f9625a4bf1cfbabde45bd13ceee3e882 100644

--- a/chrome/browser/resources/google_now/cards.js

+++ b/chrome/browser/resources/google_now/cards.js

@@ -137,8 +137,6 @@ function buildCardSet() {

console.log('cardManager.update ' + JSON.stringify(card) + ' ' +

previousVersion);

- // TODO(vadimt): Don't clear alarms etc that don't exist. Or make sure doing

- // this doesn't output an error to console.

chrome.alarms.clear(cardHidePrefix + cardId);

var cardCreateInfo = {