Move the message definitions to their own files.

Move the message definitions to their own files.

Currently the CFWL messages are created by a macro in the CFWL_Message header
file. This Cl splits out the class to their own files and writes them directly
instead of using the macro.

Committed: https://pdfium.googlesource.com/pdfium/+/242b95e2a9df3b57dd9aa28adea58ad51f84a221

[dsinclair, 2016-11-16 21:15:57]

dsinclair@chromium.org changed reviewers:
+ npm@chromium.org, tsepez@chromium.org

[dsinclair, 2016-11-16 21:15:58]

PTAL

[dsinclair, 2016-11-16 21:16:02]

The CQ bit was checked by dsinclair@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-16 21:16:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Tom Sepez, 2016-11-16 21:18:15]

RS LGTM

[commit-bot: I haz the power, 2016-11-16 21:24:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-16 21:24:17]

Dry run: Try jobs failed on following builders:
  mac_xfa on master.tryserver.client.pdfium (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.pdfium/builders/mac_xfa/builds/...)

[Tom Sepez, 2016-11-16 21:34:02]

LGTM with nits and question.

https://codereview.chromium.org/2510823003/diff/1/xfa/fwl/core/cfwl_msgkey.cpp
File xfa/fwl/core/cfwl_msgkey.cpp (right):

https://codereview.chromium.org/2510823003/diff/1/xfa/fwl/core/cfwl_msgkey.cp...
xfa/fwl/core/cfwl_msgkey.cpp:16: return pdfium::MakeUnique<CFWL_MsgKey>(*this);
This is using the default copy ctor?

https://codereview.chromium.org/2510823003/diff/1/xfa/fwl/core/cfwl_widgetmgr...
File xfa/fwl/core/cfwl_widgetmgr.cpp (right):

https://codereview.chromium.org/2510823003/diff/1/xfa/fwl/core/cfwl_widgetmgr...
xfa/fwl/core/cfwl_widgetmgr.cpp:476: auto pMsg = pMessage->Clone();
nit: I might be tempted to write out std::unique_ptr<...> here rather than auto,
since it isn't entirely clear that you're taking onwership, as opposed to
MakeUnique<...>() where the type is already on the same line.

https://codereview.chromium.org/2510823003/diff/1/xfa/fwl/core/cfwl_widgetmgr...
xfa/fwl/core/cfwl_widgetmgr.cpp:476: auto pMsg = pMessage->Clone();
nit: how about pClonedMessage as a name?

https://codereview.chromium.org/2510823003/diff/1/xfa/fwl/core/fwl_noteimp.cpp
File xfa/fwl/core/fwl_noteimp.cpp (right):

https://codereview.chromium.org/2510823003/diff/1/xfa/fwl/core/fwl_noteimp.cp...
xfa/fwl/core/fwl_noteimp.cpp:197: std::unique_ptr<CFWL_Message>
pMessage(m_noteQueue[0].release());
nit: just ... = std::move(m_noteQueue.front());

[dsinclair, 2016-11-16 21:41:07]

https://codereview.chromium.org/2510823003/diff/1/xfa/fwl/core/cfwl_msgkey.cpp
File xfa/fwl/core/cfwl_msgkey.cpp (right):

https://codereview.chromium.org/2510823003/diff/1/xfa/fwl/core/cfwl_msgkey.cp...
xfa/fwl/core/cfwl_msgkey.cpp:16: return pdfium::MakeUnique<CFWL_MsgKey>(*this);
On 2016/11/16 21:34:02, Tom Sepez wrote:
> This is using the default copy ctor?

Yea. It's what the code did originally so I kept it as it seemed sane.

https://codereview.chromium.org/2510823003/diff/1/xfa/fwl/core/cfwl_widgetmgr...
File xfa/fwl/core/cfwl_widgetmgr.cpp (right):

https://codereview.chromium.org/2510823003/diff/1/xfa/fwl/core/cfwl_widgetmgr...
xfa/fwl/core/cfwl_widgetmgr.cpp:476: auto pMsg = pMessage->Clone();
On 2016/11/16 21:34:02, Tom Sepez wrote:
> nit: how about pClonedMessage as a name?

Done.

https://codereview.chromium.org/2510823003/diff/1/xfa/fwl/core/cfwl_widgetmgr...
xfa/fwl/core/cfwl_widgetmgr.cpp:476: auto pMsg = pMessage->Clone();
On 2016/11/16 21:34:02, Tom Sepez wrote:
> nit: I might be tempted to write out std::unique_ptr<...> here rather than
auto,
> since it isn't entirely clear that you're taking onwership, as opposed to
> MakeUnique<...>() where the type is already on the same line.

Done.

https://codereview.chromium.org/2510823003/diff/1/xfa/fwl/core/fwl_noteimp.cpp
File xfa/fwl/core/fwl_noteimp.cpp (right):

https://codereview.chromium.org/2510823003/diff/1/xfa/fwl/core/fwl_noteimp.cp...
xfa/fwl/core/fwl_noteimp.cpp:197: std::unique_ptr<CFWL_Message>
pMessage(m_noteQueue[0].release());
On 2016/11/16 21:34:02, Tom Sepez wrote:
> nit: just ... = std::move(m_noteQueue.front());

Done.

[dsinclair, 2016-11-16 21:54:31]

The CQ bit was checked by dsinclair@chromium.org

[dsinclair, 2016-11-16 21:54:31]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org
Link to the patchset: https://codereview.chromium.org/2510823003/#ps40001
(title: "Review feedback")

[commit-bot: I haz the power, 2016-11-16 21:54:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-16 22:25:04]

Description was changed from

==========
Move the message definitions to their own files.

Currently the CFWL messages are created by a macro in the CFWL_Message header
file. This Cl splits out the class to their own files and writes them directly
instead of using the macro.
==========

to

==========
Move the message definitions to their own files.

Currently the CFWL messages are created by a macro in the CFWL_Message header
file. This Cl splits out the class to their own files and writes them directly
instead of using the macro.

Committed:
https://pdfium.googlesource.com/pdfium/+/242b95e2a9df3b57dd9aa28adea58ad51f84...
==========

[commit-bot: I haz the power, 2016-11-16 22:25:05]

Committed patchset #3 (id:40001) as
https://pdfium.googlesource.com/pdfium/+/242b95e2a9df3b57dd9aa28adea58ad51f84...