Chromium Code Reviews Chromium Code Reviews
Issue 2510823003:
Move the message definitions to their own files. (Closed)
| OLD | NEW |
|---|---|
| 1 // Copyright 2016 PDFium Authors. All rights reserved. | 1 // Copyright 2016 PDFium Authors. All rights reserved. |
| 2 // Use of this source code is governed by a BSD-style license that can be | 2 // Use of this source code is governed by a BSD-style license that can be |
| 3 // found in the LICENSE file. | 3 // found in the LICENSE file. |
| 4 | 4 |
| 5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com | 5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com |
| 6 | 6 |
| 7 #include "core/fpdfapi/parser/cpdf_null.h" | 7 #include "xfa/fwl/core/cfwl_msgkey.h" |
| 8 | |
| 8 #include "third_party/base/ptr_util.h" | 9 #include "third_party/base/ptr_util.h" |
| 9 | 10 |
| 10 CPDF_Null::CPDF_Null() {} | 11 CFWL_MsgKey::CFWL_MsgKey() {} |
| 11 | 12 |
| 12 CPDF_Object::Type CPDF_Null::GetType() const { | 13 CFWL_MsgKey::~CFWL_MsgKey() {} |
| 13 return NULLOBJ; | 14 |
| 15 std::unique_ptr<CFWL_Message> CFWL_MsgKey::Clone() { | |
| 16 return pdfium::MakeUnique<CFWL_MsgKey>(*this); | |
|
Tom Sepez
2016/11/16 21:34:02
This is using the default copy ctor?
dsinclair
2016/11/16 21:41:07
Yea. It's what the code did originally so I kept i
| |
| 14 } | 17 } |
| 15 | 18 |
| 16 std::unique_ptr<CPDF_Object> CPDF_Null::Clone() const { | 19 CFWL_MessageType CFWL_MsgKey::GetClassID() const { |
| 17 return pdfium::MakeUnique<CPDF_Null>(); | 20 return CFWL_MessageType::Key; |
| 18 } | 21 } |
| OLD | NEW |
