Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 2509863002: Remove ref counting from CFWL_Event (Closed)

Created:
4 years, 1 month ago by dsinclair
Modified:
4 years, 1 month ago
Reviewers:
Tom Sepez, npm
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Remove ref counting from CFWL_Event CFWL_Event has no Retain method, just a Release method. So, it's essentially just a delete call whenever used. This CL removes the Release method and turns the one usage into a unique_ptr. Committed: https://pdfium.googlesource.com/pdfium/+/038a23f297963997d631d91fefdf97598585f3ba

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -17 lines) Patch
M xfa/fwl/core/cfwl_event.h View 2 chunks +1 line, -14 lines 0 comments Download
M xfa/fwl/core/ifwl_widget.cpp View 1 chunk +2 lines, -3 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 7 (3 generated)
dsinclair
PTAL.
4 years, 1 month ago (2016-11-16 21:49:33 UTC) #2
Tom Sepez
brilliant. LGTM.
4 years, 1 month ago (2016-11-16 22:39:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2509863002/1
4 years, 1 month ago (2016-11-17 01:39:37 UTC) #5
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 01:55:13 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/038a23f297963997d631d91fefdf97598585...

Powered by Google App Engine
This is Rietveld 408576698