Cleanup: Remove "gray text" logic from Omnibox

Cleanup: Remove "gray text" logic from Omnibox

BUG=627747
Committed: https://crrev.com/1ca95c7cfa0a17fec86196cd8d37d24c2f1c65d7
Cr-Commit-Position: refs/heads/master@{#434156}

[Marc Treib, 2016-11-18 16:28:29]

The CQ bit was checked by treib@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-18 16:29:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-18 18:50:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-18 18:50:13]

Dry run: This issue passed the CQ dry run.

[Marc Treib, 2016-11-21 09:45:30]

treib@chromium.org changed reviewers:
+ pkasting@chromium.org

[Marc Treib, 2016-11-21 09:45:30]

Finally found some time for this :)  PTAL!

[Peter Kasting, 2016-11-21 21:11:43]

Thanks so much for doing this!  Excited to see this get ripped out.

Be sure you get an appropriate Mac reviewer to double-check the Mac changes, as
I don't really speak ObjC or know that code well.

https://codereview.chromium.org/2510373003/diff/40001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/location_bar/autocomplete_text_field.mm (left):

https://codereview.chromium.org/2510373003/diff/40001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/location_bar/autocomplete_text_field.mm:289:
suggestText_.reset([suggestText retain]);
I would assume suggestText_ and suggestColor_, and their accessors, should go
away.

https://codereview.chromium.org/2510373003/diff/40001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm (left):

https://codereview.chromium.org/2510373003/diff/40001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm:721: if (suggest_text ==
suggest_text_)
suggest_text_ should go away, I assume.

https://codereview.chromium.org/2510373003/diff/40001/chrome/browser/ui/views...
File chrome/browser/ui/views/location_bar/location_bar_view.cc (left):

https://codereview.chromium.org/2510373003/diff/40001/chrome/browser/ui/views...
chrome/browser/ui/views/location_bar/location_bar_view.cc:446:
suggested_text_view_->text() : base::string16();
suggested_text_view_ and HasValidSuggestText() should also be removed entirely. 
The latter is easy, removing the former will probably mean just ripping out the
whole big conditional in Layout() dealing with it (but I didn't look closely).

[Marc Treib, 2016-11-22 10:35:13]

The CQ bit was checked by treib@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-22 10:35:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Marc Treib, 2016-11-22 10:35:30]

Thanks! All addressed.

https://codereview.chromium.org/2510373003/diff/40001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/location_bar/autocomplete_text_field.mm (left):

https://codereview.chromium.org/2510373003/diff/40001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/location_bar/autocomplete_text_field.mm:289:
suggestText_.reset([suggestText retain]);
On 2016/11/21 21:11:43, Peter Kasting wrote:
> I would assume suggestText_ and suggestColor_, and their accessors, should go
> away.

Done.

https://codereview.chromium.org/2510373003/diff/40001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm (left):

https://codereview.chromium.org/2510373003/diff/40001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm:721: if (suggest_text ==
suggest_text_)
On 2016/11/21 21:11:43, Peter Kasting wrote:
> suggest_text_ should go away, I assume.

Done.

https://codereview.chromium.org/2510373003/diff/40001/chrome/browser/ui/views...
File chrome/browser/ui/views/location_bar/location_bar_view.cc (left):

https://codereview.chromium.org/2510373003/diff/40001/chrome/browser/ui/views...
chrome/browser/ui/views/location_bar/location_bar_view.cc:446:
suggested_text_view_->text() : base::string16();
On 2016/11/21 21:11:43, Peter Kasting wrote:
> suggested_text_view_ and HasValidSuggestText() should also be removed
entirely. 
> The latter is easy, removing the former will probably mean just ripping out
the
> whole big conditional in Layout() dealing with it (but I didn't look closely).

Done.

[Marc Treib, 2016-11-22 11:04:50]

treib@chromium.org changed reviewers:
+ shess@chromium.org

[Marc Treib, 2016-11-22 11:04:50]

+shess - Scott, could you double-check the cocoa changes please? Thanks!

[commit-bot: I haz the power, 2016-11-22 11:29:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-22 11:29:08]

Dry run: This issue passed the CQ dry run.

[Scott Hess - ex-Googler, 2016-11-22 19:21:59]

LGTM for cocoa/

[AFAICT with a quick glance, I don't think there were forgotten bits of
infrastructure to collapse, but it's likely we'll never know.]

[Peter Kasting, 2016-11-22 19:50:33]

LGTM!

https://codereview.chromium.org/2510373003/diff/80001/chrome/browser/ui/views...
File chrome/browser/ui/views/location_bar/location_bar_view.cc (right):

https://codereview.chromium.org/2510373003/diff/80001/chrome/browser/ui/views...
chrome/browser/ui/views/location_bar/location_bar_view.cc:655:
omnibox_view_->SetBorder(views::CreateEmptyBorder(0, 0, 0, 0));
Just remove this line, it should no longer be needed.

[Marc Treib, 2016-11-23 09:54:51]

https://codereview.chromium.org/2510373003/diff/80001/chrome/browser/ui/views...
File chrome/browser/ui/views/location_bar/location_bar_view.cc (right):

https://codereview.chromium.org/2510373003/diff/80001/chrome/browser/ui/views...
chrome/browser/ui/views/location_bar/location_bar_view.cc:655:
omnibox_view_->SetBorder(views::CreateEmptyBorder(0, 0, 0, 0));
On 2016/11/22 19:50:33, Peter Kasting wrote:
> Just remove this line, it should no longer be needed.

Done.

[Marc Treib, 2016-11-23 09:54:57]

The CQ bit was checked by treib@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-23 09:55:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-23 10:24:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-23 10:24:59]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Marc Treib, 2016-11-23 10:26:10]

The CQ bit was checked by treib@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-23 10:26:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-23 11:25:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-23 11:25:17]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Marc Treib, 2016-11-23 12:03:43]

The CQ bit was checked by treib@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-23 12:03:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-23 13:07:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-23 13:07:33]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Marc Treib, 2016-11-23 13:10:46]

The CQ bit was checked by treib@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-23 13:10:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-23 13:38:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-23 13:38:07]

Dry run: This issue passed the CQ dry run.

[Marc Treib, 2016-11-23 13:39:37]

The CQ bit was checked by treib@chromium.org

[Marc Treib, 2016-11-23 13:39:38]

The patchset sent to the CQ was uploaded after l-g-t-m from
pkasting@chromium.org, shess@chromium.org
Link to the patchset: https://codereview.chromium.org/2510373003/#ps100001
(title: "review2")

[commit-bot: I haz the power, 2016-11-23 13:39:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-23 13:43:45]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1479908377889640,
"parent_rev": "98f24b455cc83992211e7b59f0145aabd38f40a3", "commit_rev":
"159353a6a6d4a624c57844ddfb0029c3e85af8d9"}

[commit-bot: I haz the power, 2016-11-23 13:44:10]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-11-23 13:46:13]

Description was changed from

==========
Cleanup: Remove "gray text" logic from Omnibox

BUG=627747
==========

to

==========
Cleanup: Remove "gray text" logic from Omnibox

BUG=627747

Committed: https://crrev.com/1ca95c7cfa0a17fec86196cd8d37d24c2f1c65d7
Cr-Commit-Position: refs/heads/master@{#434156}
==========

[commit-bot: I haz the power, 2016-11-23 13:46:14]

Patchset 6 (id:??) landed as
https://crrev.com/1ca95c7cfa0a17fec86196cd8d37d24c2f1c65d7
Cr-Commit-Position: refs/heads/master@{#434156}