Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(948)

Unified Diff: components/omnibox/browser/omnibox_edit_model.h

Issue 2510373003: Cleanup: Remove "gray text" logic from Omnibox (Closed)
Patch Set: review2 Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/omnibox/browser/omnibox_edit_model.h
diff --git a/components/omnibox/browser/omnibox_edit_model.h b/components/omnibox/browser/omnibox_edit_model.h
index 94d67fcfebfa7221b5a76f09d8ee68b8c313896f..9fc54b241534a383375e4a8760d9886aa5afee9d 100644
--- a/components/omnibox/browser/omnibox_edit_model.h
+++ b/components/omnibox/browser/omnibox_edit_model.h
@@ -60,7 +60,6 @@ class OmniboxEditModel {
struct State {
State(bool user_input_in_progress,
const base::string16& user_text,
- const base::string16& gray_text,
const base::string16& keyword,
bool is_keyword_hint,
KeywordModeEntryMethod keyword_mode_entry_method,
@@ -72,7 +71,6 @@ class OmniboxEditModel {
bool user_input_in_progress;
const base::string16 user_text;
- const base::string16 gray_text;
const base::string16 keyword;
const bool is_keyword_hint;
KeywordModeEntryMethod keyword_mode_entry_method;
@@ -164,11 +162,6 @@ class OmniboxEditModel {
// Sets the user_text_ to |text|. Only the View should call this.
void SetUserText(const base::string16& text);
- // Commits the gray suggested text as if it's been input by the user.
- // Returns true if the text was committed.
- // TODO: can the return type be void?
- bool CommitSuggestedText();
-
// Invoked any time the text may have changed in the edit. Notifies the
// controller.
void OnChanged();
@@ -305,9 +298,6 @@ class OmniboxEditModel {
// Returns true if pasting is in progress.
bool is_pasting() const { return paste_state_ == PASTING; }
- // TODO(beaudoin): Try not to expose this.
- bool in_revert() const { return in_revert_; }
-
// Called when the user presses up or down. |count| is a repeat count,
// negative for moving up, positive for moving down.
virtual void OnUpOrDownKeyPressed(int count);
« no previous file with comments | « chrome/browser/ui/views/omnibox/omnibox_view_views.cc ('k') | components/omnibox/browser/omnibox_edit_model.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698