chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_unittest.mm - Issue 2510373003: Cleanup: Remove "gray text" logic from Omnibox

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_unittest.mm

Issue 2510373003: Cleanup: Remove "gray text" logic from Omnibox (Closed)

Patch Set: review2 Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_editor_unittest.mm ('k') | chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_unittest.mm

diff --git a/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_unittest.mm b/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_unittest.mm

index 4ca3df8b6b17ce594febe736897fd28f6713e9b5..c21c1b61ebed5c2e9ae423282c8ade8e9f2bd4ed 100644

--- a/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_unittest.mm

+++ b/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_unittest.mm

@@ -243,15 +243,6 @@ TEST_F(AutocompleteTextFieldTest, Display) {

[field_ display];

}

-// Test setting gray text, mostly to ensure nothing leaks or crashes.

-TEST_F(AutocompleteTextFieldTest, GrayText) {

- [field_ display];

- EXPECT_FALSE([field_ needsDisplay]);

- [field_ setGrayTextAutocompletion:@"foo" textColor:[NSColor redColor]];

- EXPECT_TRUE([field_ needsDisplay]);

- [field_ display];

TEST_F(AutocompleteTextFieldObserverTest, FlagsChanged) {

InSequence dummy; // Call mock in exactly the order specified.