Create CFWL_EvtEditChanged

Create CFWL_EvtEditChanged

This CL creates a generic event for CFWL_EventType::EditChanged and uses it
in the ComboBox and DateTimePicker. None of the params from the custom events
were used so they have been removed.

Committed: https://pdfium.googlesource.com/pdfium/+/b977720aa7f159ae2c1e9d9b3af1adecff730545

[dsinclair, 2016-11-17 17:07:01]

dsinclair@chromium.org changed reviewers:
+ npm@chromium.org, tsepez@chromium.org

[dsinclair, 2016-11-17 17:07:02]

PTAL.

[dsinclair, 2016-11-17 17:07:05]

The CQ bit was checked by dsinclair@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-17 17:07:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Tom Sepez, 2016-11-17 17:12:59]

lgtm

https://codereview.chromium.org/2511813002/diff/1/xfa/fwl/core/ifwl_combobox.cpp
File xfa/fwl/core/ifwl_combobox.cpp (left):

https://codereview.chromium.org/2511813002/diff/1/xfa/fwl/core/ifwl_combobox....
xfa/fwl/core/ifwl_combobox.cpp:861: pTemp.m_pSrcTarget = this;
Sure this isn't used?

https://codereview.chromium.org/2511813002/diff/1/xfa/fwl/core/ifwl_datetimep...
File xfa/fwl/core/ifwl_datetimepicker.cpp (left):

https://codereview.chromium.org/2511813002/diff/1/xfa/fwl/core/ifwl_datetimep...
xfa/fwl/core/ifwl_datetimepicker.cpp:201: ev.m_wsText = wsText;
ditto

[commit-bot: I haz the power, 2016-11-17 17:21:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-17 17:21:19]

Dry run: This issue passed the CQ dry run.

[dsinclair, 2016-11-17 18:00:13]

https://codereview.chromium.org/2511813002/diff/1/xfa/fwl/core/ifwl_combobox.cpp
File xfa/fwl/core/ifwl_combobox.cpp (left):

https://codereview.chromium.org/2511813002/diff/1/xfa/fwl/core/ifwl_combobox....
xfa/fwl/core/ifwl_combobox.cpp:861: pTemp.m_pSrcTarget = this;
On 2016/11/17 17:12:58, Tom Sepez wrote:
> Sure this isn't used?

Done. Good catch, thanks.

https://codereview.chromium.org/2511813002/diff/1/xfa/fwl/core/ifwl_datetimep...
File xfa/fwl/core/ifwl_datetimepicker.cpp (left):

https://codereview.chromium.org/2511813002/diff/1/xfa/fwl/core/ifwl_datetimep...
xfa/fwl/core/ifwl_datetimepicker.cpp:201: ev.m_wsText = wsText;
On 2016/11/17 17:12:58, Tom Sepez wrote:
> ditto

Compiles without it, so doesn't seem to be needed.

[dsinclair, 2016-11-17 18:00:37]

The CQ bit was checked by dsinclair@chromium.org

[dsinclair, 2016-11-17 18:00:38]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org
Link to the patchset: https://codereview.chromium.org/2511813002/#ps20001
(title: "fixed")

[commit-bot: I haz the power, 2016-11-17 18:00:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-17 18:32:55]

Description was changed from

==========
Create CFWL_EvtEditChanged

This CL creates a generic event for CFWL_EventType::EditChanged and uses it
in the ComboBox and DateTimePicker. None of the params from the custom events
were used so they have been removed.
==========

to

==========
Create CFWL_EvtEditChanged

This CL creates a generic event for CFWL_EventType::EditChanged and uses it
in the ComboBox and DateTimePicker. None of the params from the custom events
were used so they have been removed.

Committed:
https://pdfium.googlesource.com/pdfium/+/b977720aa7f159ae2c1e9d9b3af1adecff73...
==========

[commit-bot: I haz the power, 2016-11-17 18:32:56]

Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/b977720aa7f159ae2c1e9d9b3af1adecff73...