Handle audio node stable device ID change

Handle audio node stable device ID change

Chrome side change for updating the way stable device ID is
calculated for USB audio device nodes in order to make them more
usefull when distinguishing among USB audio devices with same
USB vendor and product IDs.

Cras will start providing new property - StableDeviceIdOld that
will contain old, now deprecated stable device ID - this will be
used to migrate audio device prefs to new stable ID (to provide
some backward compatibility). This property is expected to eventually
go away.

This does not expose new value to audio extension API, but cl will
follow - for now, keep providing old ID version through API.

Huge line diff is mostly due to refactoring test to account for
new stable device ID version :)

Parametrizes cras audio client unit tests by the version od
stable device ID provided by audio device - to ensure it keeps
working as expcted with both stable device ID version (does not
test for mixing devices with different stable device ID versions,
that is never expected to happen).

Added audio devices pref handler for migrating audio device records
when audio device stable device ID changes.

BUG=661861
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/3ab01a28f2ccd9abc62a3833d72959205ddce98b
Cr-Commit-Position: refs/heads/master@{#439304}

[tbarzic, 2016-11-17 23:11:15]

The CQ bit was checked by tbarzic@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-17 23:12:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tbarzic, 2016-11-18 01:18:08]

Description was changed from

==========
Handle audio node stable device ID change

Chrome side change for updating the way stable device ID is
calculated for USB audio device nodes in order to make them more
usefull when distinguishing among USB audio devices with same
USB vendor and product IDs.

Cras will start providing new property - StableDeviceIdOld that
will contain old, now deprecated stable device ID - this will be
used to migrate audio device prefs to new stable ID (to provide
some backward compatibility). This property is expected to eventually
go away.

This does not expose new value to audio extension API, but cl will
follow - for now, keep providing old ID version through API.

Huge line diff is mostly due to refactoring test to account for
new stable device ID version :)

Parametrizes cras audio client unit tests by the version od
stable device ID provided by audio device - to ensure it keeps
working as expcted with both stable device ID version (does not
test for mixing devices with different stable device ID versions,
that is never expected to happen).

Added audio devices pref handler for migrating audio device records
when audio device stable device ID changes.

BUG=662861
==========

to

==========
Handle audio node stable device ID change

Chrome side change for updating the way stable device ID is
calculated for USB audio device nodes in order to make them more
usefull when distinguishing among USB audio devices with same
USB vendor and product IDs.

Cras will start providing new property - StableDeviceIdOld that
will contain old, now deprecated stable device ID - this will be
used to migrate audio device prefs to new stable ID (to provide
some backward compatibility). This property is expected to eventually
go away.

This does not expose new value to audio extension API, but cl will
follow - for now, keep providing old ID version through API.

Huge line diff is mostly due to refactoring test to account for
new stable device ID version :)

Parametrizes cras audio client unit tests by the version od
stable device ID provided by audio device - to ensure it keeps
working as expcted with both stable device ID version (does not
test for mixing devices with different stable device ID versions,
that is never expected to happen).

Added audio devices pref handler for migrating audio device records
when audio device stable device ID changes.

BUG=661861
==========

[tbarzic, 2016-11-18 19:07:13]

The CQ bit was checked by tbarzic@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-18 19:08:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-18 20:16:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-18 20:17:00]

Dry run: Try jobs failed on following builders:
  chromeos_x86-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)

[tbarzic, 2016-11-18 20:52:39]

Description was changed from

==========
Handle audio node stable device ID change

Chrome side change for updating the way stable device ID is
calculated for USB audio device nodes in order to make them more
usefull when distinguishing among USB audio devices with same
USB vendor and product IDs.

Cras will start providing new property - StableDeviceIdOld that
will contain old, now deprecated stable device ID - this will be
used to migrate audio device prefs to new stable ID (to provide
some backward compatibility). This property is expected to eventually
go away.

This does not expose new value to audio extension API, but cl will
follow - for now, keep providing old ID version through API.

Huge line diff is mostly due to refactoring test to account for
new stable device ID version :)

Parametrizes cras audio client unit tests by the version od
stable device ID provided by audio device - to ensure it keeps
working as expcted with both stable device ID version (does not
test for mixing devices with different stable device ID versions,
that is never expected to happen).

Added audio devices pref handler for migrating audio device records
when audio device stable device ID changes.

BUG=661861
==========

to

==========
Handle audio node stable device ID change

Chrome side change for updating the way stable device ID is
calculated for USB audio device nodes in order to make them more
usefull when distinguishing among USB audio devices with same
USB vendor and product IDs.

Cras will start providing new property - StableDeviceIdOld that
will contain old, now deprecated stable device ID - this will be
used to migrate audio device prefs to new stable ID (to provide
some backward compatibility). This property is expected to eventually
go away.

This does not expose new value to audio extension API, but cl will
follow - for now, keep providing old ID version through API.

Huge line diff is mostly due to refactoring test to account for
new stable device ID version :)

Parametrizes cras audio client unit tests by the version od
stable device ID provided by audio device - to ensure it keeps
working as expcted with both stable device ID version (does not
test for mixing devices with different stable device ID versions,
that is never expected to happen).

Added audio devices pref handler for migrating audio device records
when audio device stable device ID changes.

BUG=661861
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[tbarzic, 2016-11-18 20:52:53]

The CQ bit was checked by tbarzic@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-18 20:54:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-18 22:31:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-18 22:31:14]

Dry run: This issue passed the CQ dry run.

[tbarzic, 2016-11-21 17:38:33]

tbarzic@chromium.org changed reviewers:
+ hychao@chromium.org, jennyz@chromium.org, mojahsu@chromium.org,
steel@chromium.org

[tbarzic, 2016-11-21 17:38:33]

mojahsu and hychao FYI
steel: extensions/browser/api/audio/

[tbarzic, 2016-11-22 19:09:31]

The CQ bit was checked by tbarzic@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-22 19:10:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-22 20:32:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-22 20:32:48]

Dry run: This issue passed the CQ dry run.

[tbarzic, 2016-11-30 01:06:21]

The CQ bit was checked by tbarzic@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-30 01:07:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-30 03:09:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-30 03:09:34]

Dry run: Try jobs failed on following builders:
  blimp_linux_dbg on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  chromeos_x86-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)
  linux_optional_gpu_tests_rel on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)

[tbarzic, 2016-11-30 21:06:15]

tbarzic@chromium.org changed reviewers:
- mojahsu@chromium.org

[tbarzic, 2016-11-30 21:06:16]

Jenny, can you please take a look at this when you have time :)
(cras side change (https://chromium-review.googlesource.com/#/c/407723/) seems
to be getting close to landing)

[jennyz, 2016-12-09 23:52:19]

https://codereview.chromium.org/2510093003/diff/140001/chromeos/audio/audio_d...
File chromeos/audio/audio_devices_pref_handler_impl.cc (right):

https://codereview.chromium.org/2510093003/diff/140001/chromeos/audio/audio_d...
chromeos/audio/audio_devices_pref_handler_impl.cc:45: int version) {
It looks like |version| can only be either 1 or 2, can you add the DCHECK to
prevent the invalid arguments be passed in?

https://codereview.chromium.org/2510093003/diff/140001/chromeos/audio/audio_d...
chromeos/audio/audio_devices_pref_handler_impl.cc:77: 
Add a DCHECK(device.stable_device_id_version == 2);

https://codereview.chromium.org/2510093003/diff/140001/chromeos/audio/audio_d...
File chromeos/audio/audio_devices_pref_handler_impl_unittest.cc (right):

https://codereview.chromium.org/2510093003/diff/140001/chromeos/audio/audio_d...
chromeos/audio/audio_devices_pref_handler_impl_unittest.cc:136: AudioDevice
GetDevice(int version) {
Can we rename it to GetDeviceWithVersion()? More self explained.

https://codereview.chromium.org/2510093003/diff/140001/chromeos/audio/audio_d...
chromeos/audio/audio_devices_pref_handler_impl_unittest.cc:145: AudioDevice
GetPresetDevice(int version) {
ditto

https://codereview.chromium.org/2510093003/diff/140001/chromeos/audio/audio_d...
chromeos/audio/audio_devices_pref_handler_impl_unittest.cc:150: AudioDevice
GetSecondaryDevice(int version) {
ditto

https://codereview.chromium.org/2510093003/diff/140001/chromeos/audio/audio_d...
chromeos/audio/audio_devices_pref_handler_impl_unittest.cc:154: AudioDevice
GetDeviceWithSpecialCharacters(int version) {
ditto

https://codereview.chromium.org/2510093003/diff/140001/chromeos/audio/audio_d...
chromeos/audio/audio_devices_pref_handler_impl_unittest.cc:266: // return
default value
Add a line to verify kDefaultSoundLevel is not equal to
kPresetState.sound_level.

https://codereview.chromium.org/2510093003/diff/140001/chromeos/audio/audio_d...
chromeos/audio/audio_devices_pref_handler_impl_unittest.cc:319: // return
default value
Add a line to verify kPresetState.mute is true, which is different that the
default mute value (false).

https://codereview.chromium.org/2510093003/diff/140001/extensions/browser/api...
File extensions/browser/api/audio/audio_apitest.cc (right):

https://codereview.chromium.org/2510093003/diff/140001/extensions/browser/api...
extensions/browser/api/audio/audio_apitest.cc:62: "HDMI output", "HDMI",       
"HDA Intel MID"};
Remove the extra white space in between.

https://codereview.chromium.org/2510093003/diff/140001/extensions/browser/api...
extensions/browser/api/audio/audio_apitest.cc:66: "Jabra Mic", "USB",       
"Jabra Mic 1"};
ditto

https://codereview.chromium.org/2510093003/diff/140001/extensions/browser/api...
extensions/browser/api/audio/audio_apitest.cc:70: "Jabra Mic", "USB",       
"Jabra Mic 2"};
ditto

https://codereview.chromium.org/2510093003/diff/140001/extensions/browser/api...
extensions/browser/api/audio/audio_apitest.cc:74: "Webcam Mic", "USB",       
"Logitech Webcam"};
ditto

https://codereview.chromium.org/2510093003/diff/140001/extensions/browser/api...
extensions/browser/api/audio/audio_apitest.cc:121: CreateAudioNode(kJabraMic2,
1),     CreateAudioNode(kUSBCameraMic, 1)};
Is git cl format ok with the extra spaces in between? Please remove them, or put
each CreateAudioNode in a single line.

https://codereview.chromium.org/2510093003/diff/140001/extensions/browser/api...
extensions/browser/api/audio/audio_apitest.cc:133: CreateAudioNode(kJabraMic2,
2),     CreateAudioNode(kUSBCameraMic, 2)};
ditto

https://codereview.chromium.org/2510093003/diff/140001/extensions/browser/api...
File extensions/browser/api/audio/audio_service_chromeos.cc (right):

https://codereview.chromium.org/2510093003/diff/140001/extensions/browser/api...
extensions/browser/api/audio/audio_service_chromeos.cc:27: // TODO(tbarzic):
Update audio API to expose new stable device ID version.
Can you file a separate bug for this work item and add the bug number here?

[tbarzic, 2016-12-10 02:33:43]

The CQ bit was checked by tbarzic@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-10 02:34:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tbarzic, 2016-12-10 02:35:08]

https://codereview.chromium.org/2510093003/diff/140001/chromeos/audio/audio_d...
File chromeos/audio/audio_devices_pref_handler_impl.cc (right):

https://codereview.chromium.org/2510093003/diff/140001/chromeos/audio/audio_d...
chromeos/audio/audio_devices_pref_handler_impl.cc:45: int version) {
On 2016/12/09 23:52:18, jennyz wrote:
> It looks like |version| can only be either 1 or 2, can you add the DCHECK to
> prevent the invalid arguments be passed in?

Done.

https://codereview.chromium.org/2510093003/diff/140001/chromeos/audio/audio_d...
chromeos/audio/audio_devices_pref_handler_impl.cc:77: 
On 2016/12/09 23:52:18, jennyz wrote:
> Add a DCHECK(device.stable_device_id_version == 2);

Done.

https://codereview.chromium.org/2510093003/diff/140001/chromeos/audio/audio_d...
File chromeos/audio/audio_devices_pref_handler_impl_unittest.cc (right):

https://codereview.chromium.org/2510093003/diff/140001/chromeos/audio/audio_d...
chromeos/audio/audio_devices_pref_handler_impl_unittest.cc:136: AudioDevice
GetDevice(int version) {
On 2016/12/09 23:52:18, jennyz wrote:
> Can we rename it to GetDeviceWithVersion()? More self explained.

Done.

https://codereview.chromium.org/2510093003/diff/140001/chromeos/audio/audio_d...
chromeos/audio/audio_devices_pref_handler_impl_unittest.cc:145: AudioDevice
GetPresetDevice(int version) {
On 2016/12/09 23:52:18, jennyz wrote:
> ditto

Done.

https://codereview.chromium.org/2510093003/diff/140001/chromeos/audio/audio_d...
chromeos/audio/audio_devices_pref_handler_impl_unittest.cc:150: AudioDevice
GetSecondaryDevice(int version) {
On 2016/12/09 23:52:18, jennyz wrote:
> ditto

Done.

https://codereview.chromium.org/2510093003/diff/140001/chromeos/audio/audio_d...
chromeos/audio/audio_devices_pref_handler_impl_unittest.cc:154: AudioDevice
GetDeviceWithSpecialCharacters(int version) {
On 2016/12/09 23:52:18, jennyz wrote:
> ditto

Done.

https://codereview.chromium.org/2510093003/diff/140001/chromeos/audio/audio_d...
chromeos/audio/audio_devices_pref_handler_impl_unittest.cc:266: // return
default value
On 2016/12/09 23:52:18, jennyz wrote:
> Add a line to verify kDefaultSoundLevel is not equal to
> kPresetState.sound_level.

Done.

https://codereview.chromium.org/2510093003/diff/140001/chromeos/audio/audio_d...
chromeos/audio/audio_devices_pref_handler_impl_unittest.cc:319: // return
default value
On 2016/12/09 23:52:18, jennyz wrote:
> Add a line to verify kPresetState.mute is true, which is different that the
> default mute value (false).

Done.

https://codereview.chromium.org/2510093003/diff/140001/extensions/browser/api...
File extensions/browser/api/audio/audio_apitest.cc (right):

https://codereview.chromium.org/2510093003/diff/140001/extensions/browser/api...
extensions/browser/api/audio/audio_apitest.cc:121: CreateAudioNode(kJabraMic2,
1),     CreateAudioNode(kUSBCameraMic, 1)};
On 2016/12/09 23:52:19, jennyz wrote:
> Is git cl format ok with the extra spaces in between? Please remove them, or
put
> each CreateAudioNode in a single line.

actually, that's what git cl format came up with (applies to all comments in
this file) :/

https://codereview.chromium.org/2510093003/diff/140001/extensions/browser/api...
File extensions/browser/api/audio/audio_service_chromeos.cc (right):

https://codereview.chromium.org/2510093003/diff/140001/extensions/browser/api...
extensions/browser/api/audio/audio_service_chromeos.cc:27: // TODO(tbarzic):
Update audio API to expose new stable device ID version.
On 2016/12/09 23:52:19, jennyz wrote:
> Can you file a separate bug for this work item and add the bug number here?

Done.

[commit-bot: I haz the power, 2016-12-10 03:55:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-10 03:55:46]

Dry run: This issue passed the CQ dry run.

[jennyz, 2016-12-12 18:18:00]

lgtm

[jennyz, 2016-12-12 18:18:06]

lgtm

lgtm

[tbarzic, 2016-12-12 18:39:00]

tbarzic@chromium.org changed reviewers:
+ tommi@chromium.org

[tbarzic, 2016-12-12 18:39:01]

+tommi - owner for media/audio/audio_manager_unittest.cc

[tommi (sloooow) - chröme, 2016-12-13 10:42:18]

lgtm

[tbarzic, 2016-12-14 19:09:48]

steel@, I still need your owner approval for extensions/browser/api/audio :)

[Rahul Chaturvedi, 2016-12-15 22:12:17]

lgtm

[tbarzic, 2016-12-16 23:29:01]

The CQ bit was checked by tbarzic@chromium.org

[tbarzic, 2016-12-16 23:29:02]

The patchset sent to the CQ was uploaded after l-g-t-m from jennyz@chromium.org
Link to the patchset: https://codereview.chromium.org/2510093003/#ps200001
(title: "media unittests to v2 stabl device id")

[commit-bot: I haz the power, 2016-12-16 23:30:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-16 23:56:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-16 23:56:23]

Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)

[tbarzic, 2016-12-17 01:42:23]

The CQ bit was checked by tbarzic@chromium.org

[tbarzic, 2016-12-17 01:42:24]

The patchset sent to the CQ was uploaded after l-g-t-m from steel@chromium.org,
tommi@chromium.org, jennyz@chromium.org
Link to the patchset: https://codereview.chromium.org/2510093003/#ps220001
(title: "fix a typo")

[commit-bot: I haz the power, 2016-12-17 01:43:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-17 03:12:57]

CQ is committing da patch.

Bot data: {"patchset_id": 220001, "attempt_start_ts": 1481938943369890,
"parent_rev": "63e7ec2572602282b379b1d2e9b2eae99506ba3a", "commit_rev":
"ea555eb21aa8828c2779610b6aa34cadbb68c8b2"}

[commit-bot: I haz the power, 2016-12-17 03:13:29]

Description was changed from

==========
Handle audio node stable device ID change

Chrome side change for updating the way stable device ID is
calculated for USB audio device nodes in order to make them more
usefull when distinguishing among USB audio devices with same
USB vendor and product IDs.

Cras will start providing new property - StableDeviceIdOld that
will contain old, now deprecated stable device ID - this will be
used to migrate audio device prefs to new stable ID (to provide
some backward compatibility). This property is expected to eventually
go away.

This does not expose new value to audio extension API, but cl will
follow - for now, keep providing old ID version through API.

Huge line diff is mostly due to refactoring test to account for
new stable device ID version :)

Parametrizes cras audio client unit tests by the version od
stable device ID provided by audio device - to ensure it keeps
working as expcted with both stable device ID version (does not
test for mixing devices with different stable device ID versions,
that is never expected to happen).

Added audio devices pref handler for migrating audio device records
when audio device stable device ID changes.

BUG=661861
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Handle audio node stable device ID change

Chrome side change for updating the way stable device ID is
calculated for USB audio device nodes in order to make them more
usefull when distinguishing among USB audio devices with same
USB vendor and product IDs.

Cras will start providing new property - StableDeviceIdOld that
will contain old, now deprecated stable device ID - this will be
used to migrate audio device prefs to new stable ID (to provide
some backward compatibility). This property is expected to eventually
go away.

This does not expose new value to audio extension API, but cl will
follow - for now, keep providing old ID version through API.

Huge line diff is mostly due to refactoring test to account for
new stable device ID version :)

Parametrizes cras audio client unit tests by the version od
stable device ID provided by audio device - to ensure it keeps
working as expcted with both stable device ID version (does not
test for mixing devices with different stable device ID versions,
that is never expected to happen).

Added audio devices pref handler for migrating audio device records
when audio device stable device ID changes.

BUG=661861
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2510093003
==========

[commit-bot: I haz the power, 2016-12-17 03:13:31]

Committed patchset #12 (id:220001)

[commit-bot: I haz the power, 2016-12-17 03:15:36]

Description was changed from

==========
Handle audio node stable device ID change

Chrome side change for updating the way stable device ID is
calculated for USB audio device nodes in order to make them more
usefull when distinguishing among USB audio devices with same
USB vendor and product IDs.

Cras will start providing new property - StableDeviceIdOld that
will contain old, now deprecated stable device ID - this will be
used to migrate audio device prefs to new stable ID (to provide
some backward compatibility). This property is expected to eventually
go away.

This does not expose new value to audio extension API, but cl will
follow - for now, keep providing old ID version through API.

Huge line diff is mostly due to refactoring test to account for
new stable device ID version :)

Parametrizes cras audio client unit tests by the version od
stable device ID provided by audio device - to ensure it keeps
working as expcted with both stable device ID version (does not
test for mixing devices with different stable device ID versions,
that is never expected to happen).

Added audio devices pref handler for migrating audio device records
when audio device stable device ID changes.

BUG=661861
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2510093003
==========

to

==========
Handle audio node stable device ID change

Chrome side change for updating the way stable device ID is
calculated for USB audio device nodes in order to make them more
usefull when distinguishing among USB audio devices with same
USB vendor and product IDs.

Cras will start providing new property - StableDeviceIdOld that
will contain old, now deprecated stable device ID - this will be
used to migrate audio device prefs to new stable ID (to provide
some backward compatibility). This property is expected to eventually
go away.

This does not expose new value to audio extension API, but cl will
follow - for now, keep providing old ID version through API.

Huge line diff is mostly due to refactoring test to account for
new stable device ID version :)

Parametrizes cras audio client unit tests by the version od
stable device ID provided by audio device - to ensure it keeps
working as expcted with both stable device ID version (does not
test for mixing devices with different stable device ID versions,
that is never expected to happen).

Added audio devices pref handler for migrating audio device records
when audio device stable device ID changes.

BUG=661861
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/3ab01a28f2ccd9abc62a3833d72959205ddce98b
Cr-Commit-Position: refs/heads/master@{#439304}
==========

[commit-bot: I haz the power, 2016-12-17 03:15:37]

Patchset 12 (id:??) landed as
https://crrev.com/3ab01a28f2ccd9abc62a3833d72959205ddce98b
Cr-Commit-Position: refs/heads/master@{#439304}