Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Side by Side Diff: chromeos/dbus/cras_audio_client.cc

Issue 2510093003: Handle audio node stable device ID change (Closed)
Patch Set: fix a typo Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chromeos/dbus/audio_node.cc ('k') | chromeos/dbus/cras_audio_client_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chromeos/dbus/cras_audio_client.h" 5 #include "chromeos/dbus/cras_audio_client.h"
6 6
7 #include <stdint.h> 7 #include <stdint.h>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/format_macros.h" 10 #include "base/format_macros.h"
(...skipping 408 matching lines...) Expand 10 before | Expand all | Expand 10 after
419 reader.PopString(&error_message); 419 reader.PopString(&error_message);
420 } else { 420 } else {
421 error_name = kNoResponseError; 421 error_name = kNoResponseError;
422 error_message = ""; 422 error_message = "";
423 } 423 }
424 error_callback.Run(error_name, error_message); 424 error_callback.Run(error_name, error_message);
425 } 425 }
426 426
427 bool GetAudioNode(dbus::Response* response, 427 bool GetAudioNode(dbus::Response* response,
428 dbus::MessageReader* array_reader, 428 dbus::MessageReader* array_reader,
429 AudioNode *node) { 429 AudioNode* node) {
430 while (array_reader->HasMoreData()) { 430 while (array_reader->HasMoreData()) {
431 dbus::MessageReader dict_entry_reader(response); 431 dbus::MessageReader dict_entry_reader(response);
432 dbus::MessageReader value_reader(response); 432 dbus::MessageReader value_reader(response);
433 std::string key; 433 std::string key;
434 if (!array_reader->PopDictEntry(&dict_entry_reader) || 434 if (!array_reader->PopDictEntry(&dict_entry_reader) ||
435 !dict_entry_reader.PopString(&key) || 435 !dict_entry_reader.PopString(&key) ||
436 !dict_entry_reader.PopVariant(&value_reader)) { 436 !dict_entry_reader.PopVariant(&value_reader)) {
437 return false; 437 return false;
438 } 438 }
439 439
(...skipping 15 matching lines...) Expand all
455 } else if (key == cras::kActiveProperty) { 455 } else if (key == cras::kActiveProperty) {
456 if (!value_reader.PopBool(&node->active)) 456 if (!value_reader.PopBool(&node->active))
457 return false; 457 return false;
458 } else if (key == cras::kPluggedTimeProperty) { 458 } else if (key == cras::kPluggedTimeProperty) {
459 if (!value_reader.PopUint64(&node->plugged_time)) 459 if (!value_reader.PopUint64(&node->plugged_time))
460 return false; 460 return false;
461 } else if (key == cras::kMicPositionsProperty) { 461 } else if (key == cras::kMicPositionsProperty) {
462 if (!value_reader.PopString(&node->mic_positions)) 462 if (!value_reader.PopString(&node->mic_positions))
463 return false; 463 return false;
464 } else if (key == cras::kStableDeviceIdProperty) { 464 } else if (key == cras::kStableDeviceIdProperty) {
465 if (!value_reader.PopUint64(&node->stable_device_id)) 465 if (!value_reader.PopUint64(&node->stable_device_id_v1))
466 return false; 466 return false;
467 } else if (key == cras::kStableDeviceIdNewProperty) {
468 if (!value_reader.PopUint64(&node->stable_device_id_v2))
469 return false;
470 node->has_v2_stable_device_id = true;
467 } 471 }
468 } 472 }
469 473
470 return true; 474 return true;
471 } 475 }
472 476
473 dbus::ObjectProxy* cras_proxy_; 477 dbus::ObjectProxy* cras_proxy_;
474 base::ObserverList<Observer> observers_; 478 base::ObserverList<Observer> observers_;
475 479
476 // Note: This should remain the last member so it'll be destroyed and 480 // Note: This should remain the last member so it'll be destroyed and
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
508 512
509 CrasAudioClient::~CrasAudioClient() { 513 CrasAudioClient::~CrasAudioClient() {
510 } 514 }
511 515
512 // static 516 // static
513 CrasAudioClient* CrasAudioClient::Create() { 517 CrasAudioClient* CrasAudioClient::Create() {
514 return new CrasAudioClientImpl(); 518 return new CrasAudioClientImpl();
515 } 519 }
516 520
517 } // namespace chromeos 521 } // namespace chromeos
OLDNEW
« no previous file with comments | « chromeos/dbus/audio_node.cc ('k') | chromeos/dbus/cras_audio_client_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698