Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 2507713003: Split the common event classes out to files. (Closed)

Created:
4 years, 1 month ago by dsinclair
Modified:
4 years, 1 month ago
Reviewers:
Tom Sepez, npm
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Split the common event classes out to files. This CL splits the common event classes out to individual files instead of being created by the macro. The other classes will be split out in subsequent CLs. Committed: https://pdfium.googlesource.com/pdfium/+/0baa5c719a44875789898e12c247b8c719c27815

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+300 lines, -109 lines) Patch
M BUILD.gn View 1 chunk +19 lines, -0 lines 0 comments Download
M xfa/fwl/core/cfwl_event.h View 3 chunks +0 lines, -59 lines 0 comments Download
A + xfa/fwl/core/cfwl_event.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
A xfa/fwl/core/cfwl_evtclick.h View 1 chunk +20 lines, -0 lines 0 comments Download
A + xfa/fwl/core/cfwl_evtclick.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
A xfa/fwl/core/cfwl_evtclose.h View 1 chunk +20 lines, -0 lines 0 comments Download
A + xfa/fwl/core/cfwl_evtclose.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
A xfa/fwl/core/cfwl_evtkey.h View 1 chunk +24 lines, -0 lines 0 comments Download
A + xfa/fwl/core/cfwl_evtkey.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
A xfa/fwl/core/cfwl_evtkillfocus.h View 1 chunk +22 lines, -0 lines 0 comments Download
A + xfa/fwl/core/cfwl_evtkillfocus.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
A xfa/fwl/core/cfwl_evtmouse.h View 1 chunk +25 lines, -0 lines 0 comments Download
A + xfa/fwl/core/cfwl_evtmouse.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
A xfa/fwl/core/cfwl_evtmousewheel.h View 1 chunk +26 lines, -0 lines 0 comments Download
A + xfa/fwl/core/cfwl_evtmousewheel.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
A xfa/fwl/core/cfwl_evtscroll.h View 1 chunk +37 lines, -0 lines 0 comments Download
A + xfa/fwl/core/cfwl_evtscroll.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
A xfa/fwl/core/cfwl_evtsetfocus.h View 1 chunk +22 lines, -0 lines 0 comments Download
A + xfa/fwl/core/cfwl_evtsetfocus.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
A xfa/fwl/core/cfwl_evtsizechanged.h View 1 chunk +24 lines, -0 lines 0 comments Download
A + xfa/fwl/core/cfwl_evtsizechanged.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
M xfa/fwl/core/ifwl_form.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M xfa/fwl/core/ifwl_pushbutton.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M xfa/fwl/core/ifwl_scrollbar.h View 1 chunk +1 line, -0 lines 0 comments Download
M xfa/fwl/core/ifwl_widget.cpp View 1 chunk +6 lines, -0 lines 0 comments Download
M xfa/fxfa/app/xfa_fffield.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 7 (3 generated)
dsinclair
PTAL. This is all just moving the code out. No changes to functionality.
4 years, 1 month ago (2016-11-16 22:21:20 UTC) #2
Tom Sepez
RS LGTM
4 years, 1 month ago (2016-11-16 22:41:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2507713003/1
4 years, 1 month ago (2016-11-17 01:59:37 UTC) #5
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 02:15:07 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/0baa5c719a44875789898e12c247b8c719c2...

Powered by Google App Engine
This is Rietveld 408576698