third_party/WebKit/Source/web/WebCryptoNormalize.cpp - Issue 2509713002: binding: Makes Dictionary throw an exception (constructor).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebCryptoNormalize.cpp

Issue 2509713002: binding: Makes Dictionary throw an exception (constructor). (Closed)

Patch Set: Addressed review comments. Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/WebCryptoNormalize.cpp

diff --git a/third_party/WebKit/Source/web/WebCryptoNormalize.cpp b/third_party/WebKit/Source/web/WebCryptoNormalize.cpp

index 65ed74804b11e5dd74326ebf634a36d0a1a5b671..16eabee03df2b59ef1e9a6bf88bc33d2cf7f178b 100644

--- a/third_party/WebKit/Source/web/WebCryptoNormalize.cpp

+++ b/third_party/WebKit/Source/web/WebCryptoNormalize.cpp

@@ -48,7 +48,7 @@ WebCryptoAlgorithm normalizeCryptoAlgorithm(

v8::Isolate* isolate) {

// FIXME: Avoid using NonThrowableExceptionState.

NonThrowableExceptionState exceptionState;

- Dictionary algorithmDictionary(algorithmObject, isolate, exceptionState);

+ Dictionary algorithmDictionary(isolate, algorithmObject, exceptionState);

if (!algorithmDictionary.isUndefinedOrNull() &&

!algorithmDictionary.isObject())

return WebCryptoAlgorithm();

« no previous file with comments | « third_party/WebKit/Source/core/animation/KeyframeEffectTest.cpp ('k') | no next file » | no next file with comments »