Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Unified Diff: third_party/WebKit/Source/core/animation/KeyframeEffectTest.cpp

Issue 2509713002: binding: Makes Dictionary throw an exception (constructor). (Closed)
Patch Set: Addressed review comments. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/animation/KeyframeEffectTest.cpp
diff --git a/third_party/WebKit/Source/core/animation/KeyframeEffectTest.cpp b/third_party/WebKit/Source/core/animation/KeyframeEffectTest.cpp
index ca5e733661fb2d610f75a017705b8b82b27a8c87..0a9c48ad4722476a7141d2472233760609e45bbc 100644
--- a/third_party/WebKit/Source/core/animation/KeyframeEffectTest.cpp
+++ b/third_party/WebKit/Source/core/animation/KeyframeEffectTest.cpp
@@ -67,6 +67,8 @@ class AnimationKeyframeEffectV8Test : public KeyframeEffectTest {
TEST_F(AnimationKeyframeEffectV8Test, CanCreateAnAnimation) {
V8TestingScope scope;
+ NonThrowableExceptionState exceptionState;
+
Vector<Dictionary> jsKeyframes;
v8::Local<v8::Object> keyframe1 = v8::Object::New(scope.isolate());
v8::Local<v8::Object> keyframe2 = v8::Object::New(scope.isolate());
@@ -80,8 +82,8 @@ TEST_F(AnimationKeyframeEffectV8Test, CanCreateAnAnimation) {
setV8ObjectPropertyAsString(scope.isolate(), keyframe2, "easing",
"cubic-bezier(1, 1, 0.3, 0.3)");
- jsKeyframes.append(Dictionary(scope.isolate(), keyframe1));
- jsKeyframes.append(Dictionary(scope.isolate(), keyframe2));
+ jsKeyframes.append(Dictionary(scope.isolate(), keyframe1, exceptionState));
+ jsKeyframes.append(Dictionary(scope.isolate(), keyframe2, exceptionState));
String value1;
ASSERT_TRUE(DictionaryHelper::get(jsKeyframes[0], "width", value1));
« no previous file with comments | « third_party/WebKit/Source/core/animation/EffectInputTest.cpp ('k') | third_party/WebKit/Source/web/WebCryptoNormalize.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698