Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Side by Side Diff: third_party/WebKit/Source/web/WebCryptoNormalize.cpp

Issue 2509713002: binding: Makes Dictionary throw an exception (constructor). (Closed)
Patch Set: Addressed review comments. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/core/animation/KeyframeEffectTest.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 30 matching lines...) Expand all
41 namespace blink { 41 namespace blink {
42 42
43 WebCryptoAlgorithm normalizeCryptoAlgorithm( 43 WebCryptoAlgorithm normalizeCryptoAlgorithm(
44 v8::Local<v8::Object> algorithmObject, 44 v8::Local<v8::Object> algorithmObject,
45 WebCryptoOperation operation, 45 WebCryptoOperation operation,
46 int* exceptionCode, 46 int* exceptionCode,
47 WebString* errorDetails, 47 WebString* errorDetails,
48 v8::Isolate* isolate) { 48 v8::Isolate* isolate) {
49 // FIXME: Avoid using NonThrowableExceptionState. 49 // FIXME: Avoid using NonThrowableExceptionState.
50 NonThrowableExceptionState exceptionState; 50 NonThrowableExceptionState exceptionState;
51 Dictionary algorithmDictionary(algorithmObject, isolate, exceptionState); 51 Dictionary algorithmDictionary(isolate, algorithmObject, exceptionState);
52 if (!algorithmDictionary.isUndefinedOrNull() && 52 if (!algorithmDictionary.isUndefinedOrNull() &&
53 !algorithmDictionary.isObject()) 53 !algorithmDictionary.isObject())
54 return WebCryptoAlgorithm(); 54 return WebCryptoAlgorithm();
55 WebCryptoAlgorithm algorithm; 55 WebCryptoAlgorithm algorithm;
56 AlgorithmError error; 56 AlgorithmError error;
57 AlgorithmIdentifier algorithmIdentifier; 57 AlgorithmIdentifier algorithmIdentifier;
58 algorithmIdentifier.setDictionary(algorithmDictionary); 58 algorithmIdentifier.setDictionary(algorithmDictionary);
59 if (!normalizeAlgorithm(algorithmIdentifier, operation, algorithm, &error)) { 59 if (!normalizeAlgorithm(algorithmIdentifier, operation, algorithm, &error)) {
60 *exceptionCode = webCryptoErrorToExceptionCode(error.errorType); 60 *exceptionCode = webCryptoErrorToExceptionCode(error.errorType);
61 *errorDetails = error.errorDetails; 61 *errorDetails = error.errorDetails;
62 return WebCryptoAlgorithm(); 62 return WebCryptoAlgorithm();
63 } 63 }
64 64
65 return algorithm; 65 return algorithm;
66 } 66 }
67 67
68 } // namespace blink 68 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/animation/KeyframeEffectTest.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698