Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: third_party/WebKit/Source/core/animation/EffectInputTest.cpp

Issue 2509713002: binding: Makes Dictionary throw an exception (constructor). (Closed)
Patch Set: Addressed review comments. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/bindings/tests/results/core/V8TestObject.cpp ('k') | third_party/WebKit/Source/core/animation/KeyframeEffectTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/animation/EffectInputTest.cpp
diff --git a/third_party/WebKit/Source/core/animation/EffectInputTest.cpp b/third_party/WebKit/Source/core/animation/EffectInputTest.cpp
index a25aff27a8722e04fd8e3e9b99bc62f96022bfaf..60189abcae09979d0fe3f48bc023b1e59e3d846e 100644
--- a/third_party/WebKit/Source/core/animation/EffectInputTest.cpp
+++ b/third_party/WebKit/Source/core/animation/EffectInputTest.cpp
@@ -37,9 +37,9 @@ TEST(AnimationEffectInputTest, SortedOffsets) {
setV8ObjectPropertyAsString(scope.isolate(), keyframe2, "offset", "1");
jsKeyframes.append(
- Dictionary(keyframe1, scope.isolate(), scope.getExceptionState()));
+ Dictionary(scope.isolate(), keyframe1, scope.getExceptionState()));
jsKeyframes.append(
- Dictionary(keyframe2, scope.isolate(), scope.getExceptionState()));
+ Dictionary(scope.isolate(), keyframe2, scope.getExceptionState()));
Element* element = appendElement(scope.document());
EffectModel* animationEffect = EffectInput::convert(
@@ -64,9 +64,9 @@ TEST(AnimationEffectInputTest, UnsortedOffsets) {
setV8ObjectPropertyAsString(scope.isolate(), keyframe2, "offset", "0");
jsKeyframes.append(
- Dictionary(keyframe1, scope.isolate(), scope.getExceptionState()));
+ Dictionary(scope.isolate(), keyframe1, scope.getExceptionState()));
jsKeyframes.append(
- Dictionary(keyframe2, scope.isolate(), scope.getExceptionState()));
+ Dictionary(scope.isolate(), keyframe2, scope.getExceptionState()));
Element* element = appendElement(scope.document());
EffectInput::convert(
@@ -91,11 +91,11 @@ TEST(AnimationEffectInputTest, LooslySorted) {
setV8ObjectPropertyAsString(scope.isolate(), keyframe3, "offset", "1");
jsKeyframes.append(
- Dictionary(keyframe1, scope.isolate(), scope.getExceptionState()));
+ Dictionary(scope.isolate(), keyframe1, scope.getExceptionState()));
jsKeyframes.append(
- Dictionary(keyframe2, scope.isolate(), scope.getExceptionState()));
+ Dictionary(scope.isolate(), keyframe2, scope.getExceptionState()));
jsKeyframes.append(
- Dictionary(keyframe3, scope.isolate(), scope.getExceptionState()));
+ Dictionary(scope.isolate(), keyframe3, scope.getExceptionState()));
Element* element = appendElement(scope.document());
EffectModel* animationEffect = EffectInput::convert(
@@ -125,13 +125,13 @@ TEST(AnimationEffectInputTest, OutOfOrderWithNullOffsets) {
setV8ObjectPropertyAsString(scope.isolate(), keyframe4, "offset", "1");
jsKeyframes.append(
- Dictionary(keyframe1, scope.isolate(), scope.getExceptionState()));
+ Dictionary(scope.isolate(), keyframe1, scope.getExceptionState()));
jsKeyframes.append(
- Dictionary(keyframe2, scope.isolate(), scope.getExceptionState()));
+ Dictionary(scope.isolate(), keyframe2, scope.getExceptionState()));
jsKeyframes.append(
- Dictionary(keyframe3, scope.isolate(), scope.getExceptionState()));
+ Dictionary(scope.isolate(), keyframe3, scope.getExceptionState()));
jsKeyframes.append(
- Dictionary(keyframe4, scope.isolate(), scope.getExceptionState()));
+ Dictionary(scope.isolate(), keyframe4, scope.getExceptionState()));
Element* element = appendElement(scope.document());
EffectInput::convert(
@@ -156,11 +156,11 @@ TEST(AnimationEffectInputTest, Invalid) {
setV8ObjectPropertyAsString(scope.isolate(), keyframe3, "offset", "0");
jsKeyframes.append(
- Dictionary(keyframe1, scope.isolate(), scope.getExceptionState()));
+ Dictionary(scope.isolate(), keyframe1, scope.getExceptionState()));
jsKeyframes.append(
- Dictionary(keyframe2, scope.isolate(), scope.getExceptionState()));
+ Dictionary(scope.isolate(), keyframe2, scope.getExceptionState()));
jsKeyframes.append(
- Dictionary(keyframe3, scope.isolate(), scope.getExceptionState()));
+ Dictionary(scope.isolate(), keyframe3, scope.getExceptionState()));
Element* element = appendElement(scope.document());
EffectInput::convert(
« no previous file with comments | « third_party/WebKit/Source/bindings/tests/results/core/V8TestObject.cpp ('k') | third_party/WebKit/Source/core/animation/KeyframeEffectTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698