[wasm] Refactor interface to WasmCompiledModule

[wasm] Refactor interface to WasmCompiledModule

The ptr_to_* methods do (often unnecessary) type checks, and can
return nullptr. This is problematic since the handlified getter
uses them, and assumes the result to be non-null. So change
them to only to a DCHECK and never return nullptr, and introduce
maybe_ptr_to_* with the old semantics.

R=titzer@chromium.org, ahaas@chromium.org

Committed: https://crrev.com/8b306c633676476c295ea49642b0fe1f9b271d8f
Cr-Commit-Position: refs/heads/master@{#41079}

[Clemens Hammacher, 2016-11-17 13:57:35]

The CQ bit was checked by clemensh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-17 13:57:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Clemens Hammacher, 2016-11-17 14:07:13]

Description was changed from

==========
[wasm] Refactor interface to WasmCompiledModule

The ptr_to_* methods do (often) unneccessary type checks, so change
them to only to a DCHECK and never return nullptr, and introduce
maybe_ptr_to_* with the old semantics.

R=titzer@chromium.org
==========

to

==========
[wasm] Refactor interface to WasmCompiledModule

The ptr_to_* methods do (often) unneccessary type checks, so change
them to only to a DCHECK and never return nullptr, and introduce
maybe_ptr_to_* with the old semantics.

R=titzer@chromium.org, ahaas@chromium.org
==========

[Clemens Hammacher, 2016-11-17 14:07:14]

clemensh@chromium.org changed reviewers:
+ ahaas@chromium.org

[commit-bot: I haz the power, 2016-11-17 14:24:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-17 14:24:51]

Dry run: This issue passed the CQ dry run.

[Clemens Hammacher, 2016-11-17 14:27:09]

Description was changed from

==========
[wasm] Refactor interface to WasmCompiledModule

The ptr_to_* methods do (often) unneccessary type checks, so change
them to only to a DCHECK and never return nullptr, and introduce
maybe_ptr_to_* with the old semantics.

R=titzer@chromium.org, ahaas@chromium.org
==========

to

==========
[wasm] Refactor interface to WasmCompiledModule

The ptr_to_* methods do (often unnecessary) type checks, and can
return nullptr. This is problematic since the handlified getter
uses them, and assumes the result to be non-null. So change
them to only to a DCHECK and never return nullptr, and introduce
maybe_ptr_to_* with the old semantics.

R=titzer@chromium.org, ahaas@chromium.org
==========

[titzer, 2016-11-17 14:38:45]

lgtm

[Clemens Hammacher, 2016-11-17 15:07:36]

The CQ bit was checked by clemensh@chromium.org

[commit-bot: I haz the power, 2016-11-17 15:07:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-17 15:10:01]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-11-17 22:38:25]

Description was changed from

==========
[wasm] Refactor interface to WasmCompiledModule

The ptr_to_* methods do (often unnecessary) type checks, and can
return nullptr. This is problematic since the handlified getter
uses them, and assumes the result to be non-null. So change
them to only to a DCHECK and never return nullptr, and introduce
maybe_ptr_to_* with the old semantics.

R=titzer@chromium.org, ahaas@chromium.org
==========

to

==========
[wasm] Refactor interface to WasmCompiledModule

The ptr_to_* methods do (often unnecessary) type checks, and can
return nullptr. This is problematic since the handlified getter
uses them, and assumes the result to be non-null. So change
them to only to a DCHECK and never return nullptr, and introduce
maybe_ptr_to_* with the old semantics.

R=titzer@chromium.org, ahaas@chromium.org

Committed: https://crrev.com/8b306c633676476c295ea49642b0fe1f9b271d8f
Cr-Commit-Position: refs/heads/master@{#41079}
==========

[commit-bot: I haz the power, 2016-11-17 22:38:26]

Patchset 1 (id:??) landed as
https://crrev.com/8b306c633676476c295ea49642b0fe1f9b271d8f
Cr-Commit-Position: refs/heads/master@{#41079}