Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 2503403005: [wasm] Remove two obsolete functions (Closed)

Created:
4 years, 1 month ago by Clemens Hammacher
Modified:
4 years, 1 month ago
Reviewers:
titzer, ahaas
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Remove two obsolete functions With the new wasm object types, the GetCompiledModule and GetWasmBytes functions are not needed any more. The same functions are already public on the wasm objects. In order to use them properly, I changed a few more locations to make use of the new types. R=ahaas@chromium.org, titzer@chromium.org Committed: https://crrev.com/a80d4d0314bf70c4e0db33f88f97cc0c4f227ae6 Cr-Commit-Position: refs/heads/master@{#41085}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -37 lines) Patch
M src/runtime/runtime-debug.cc View 2 chunks +9 lines, -5 lines 0 comments Download
M src/wasm/wasm-debug.cc View 3 chunks +13 lines, -11 lines 0 comments Download
M src/wasm/wasm-module.h View 2 chunks +0 lines, -6 lines 0 comments Download
M src/wasm/wasm-module.cc View 2 chunks +3 lines, -13 lines 0 comments Download
M src/wasm/wasm-objects.h View 1 chunk +2 lines, -2 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 15 (10 generated)
Clemens Hammacher
4 years, 1 month ago (2016-11-17 14:38:28 UTC) #5
titzer
On 2016/11/17 14:38:28, Clemens Hammacher wrote: lgtm
4 years, 1 month ago (2016-11-17 14:40:17 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2503403005/1
4 years, 1 month ago (2016-11-17 16:14:18 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-17 16:16:40 UTC) #13
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:38:44 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a80d4d0314bf70c4e0db33f88f97cc0c4f227ae6
Cr-Commit-Position: refs/heads/master@{#41085}

Powered by Google App Engine
This is Rietveld 408576698