Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(648)

Issue 2511763002: [wasm] Quick-fix gc error (Closed)

Created:
4 years, 1 month ago by Clemens Hammacher
Modified:
4 years, 1 month ago
Reviewers:
titzer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Quick-fix gc error R=titzer@chromium.org NOTRY=true NOTREECHECKS=true Committed: https://crrev.com/200cbe9235a34783ac3aaaf76c883a5dd86965dc Cr-Commit-Position: refs/heads/master@{#41082}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/wasm/wasm-module.cc View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 7 (2 generated)
Clemens Hammacher
4 years, 1 month ago (2016-11-17 15:30:35 UTC) #1
titzer
lgtm
4 years, 1 month ago (2016-11-17 15:32:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2511763002/1
4 years, 1 month ago (2016-11-17 15:33:15 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-17 15:35:35 UTC) #5
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:38:33 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/200cbe9235a34783ac3aaaf76c883a5dd86965dc
Cr-Commit-Position: refs/heads/master@{#41082}

Powered by Google App Engine
This is Rietveld 408576698