Cleanup: Refactor ManagedModeInterstitial to not "delete this" in the ctor.

Cleanup: Refactor ManagedModeInterstitial to not "delete this" in the ctor.

BUG=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266766

[Bernhard Bauer, 2014-04-25 11:10:18]

https://codereview.chromium.org/250803004/diff/20001/chrome/browser/managed_m...
File chrome/browser/managed_mode/managed_mode_interstitial.cc (right):

https://codereview.chromium.org/250803004/diff/20001/chrome/browser/managed_m...
chrome/browser/managed_mode/managed_mode_interstitial.cc:48: // Else
|interstitial_page_| is responsible for deleting it.
Nit: "Otherwise" instead of "else".

https://codereview.chromium.org/250803004/diff/20001/chrome/browser/managed_m...
File chrome/browser/managed_mode/managed_mode_interstitial.h (right):

https://codereview.chromium.org/250803004/diff/20001/chrome/browser/managed_m...
chrome/browser/managed_mode/managed_mode_interstitial.h:26: virtual
~ManagedModeInterstitial();
The destructor doesn't need to be public either. No one should ever get a
pointer to this class :)

[Marc Treib, 2014-04-25 12:02:19]

Thanks for the comments!

https://codereview.chromium.org/250803004/diff/20001/chrome/browser/managed_m...
File chrome/browser/managed_mode/managed_mode_interstitial.cc (right):

https://codereview.chromium.org/250803004/diff/20001/chrome/browser/managed_m...
chrome/browser/managed_mode/managed_mode_interstitial.cc:48: // Else
|interstitial_page_| is responsible for deleting it.
On 2014/04/25 11:10:18, Bernhard Bauer wrote:
> Nit: "Otherwise" instead of "else".

Done.

https://codereview.chromium.org/250803004/diff/20001/chrome/browser/managed_m...
File chrome/browser/managed_mode/managed_mode_interstitial.h (right):

https://codereview.chromium.org/250803004/diff/20001/chrome/browser/managed_m...
chrome/browser/managed_mode/managed_mode_interstitial.h:26: virtual
~ManagedModeInterstitial();
On 2014/04/25 11:10:18, Bernhard Bauer wrote:
> The destructor doesn't need to be public either. No one should ever get a
> pointer to this class :)

Done. Good point!

[Bernhard Bauer, 2014-04-25 12:16:06]

lgtm

[Marc Treib, 2014-04-28 07:25:21]

The CQ bit was checked by treib@chromium.org

[commit-bot: I haz the power, 2014-04-28 07:26:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/treib@chromium.org/250803004/40001

[commit-bot: I haz the power, 2014-04-28 07:59:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-28 07:59:35]

Try jobs failed on following builders:
  tryserver.chromium on mac_chromium_rel

[Marc Treib, 2014-04-28 10:35:26]

The CQ bit was checked by treib@chromium.org

[commit-bot: I haz the power, 2014-04-28 10:36:20]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/treib@chromium.org/250803004/40001

[commit-bot: I haz the power, 2014-04-28 13:34:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-28 13:34:19]

Try jobs failed on following builders:
  tryserver.chromium on android_dbg_triggered_tests

[Marc Treib, 2014-04-28 14:58:26]

The CQ bit was checked by treib@chromium.org

[commit-bot: I haz the power, 2014-04-28 14:58:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/treib@chromium.org/250803004/40001

[commit-bot: I haz the power, 2014-04-28 16:39:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-28 16:39:22]

Try jobs failed on following builders:
  tryserver.chromium on android_dbg_triggered_tests

[Marc Treib, 2014-04-29 07:27:39]

The CQ bit was checked by treib@chromium.org

[commit-bot: I haz the power, 2014-04-29 07:29:04]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/treib@chromium.org/250803004/40001

[commit-bot: I haz the power, 2014-04-29 07:30:46]

Change committed as 266766