Cleanup: Refactor ManagedModeInterstitial to not "delete this" in the ctor.

chrome/browser/managed_mode/managed_mode_interstitial.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_MANAGED_MODE_MANAGED_MODE_INTERSTITIAL_H_
 #define CHROME_BROWSER_MANAGED_MODE_MANAGED_MODE_INTERSTITIAL_H_
 
 #include <string>
 
 #include "base/callback.h"
 #include "base/compiler_specific.h"
 #include "base/prefs/pref_change_registrar.h"
 #include "content/public/browser/interstitial_page_delegate.h"
 #include "url/gurl.h"
 
 namespace content {
 class InterstitialPage;
 class WebContents;
 }
 
 // Delegate for an interstitial page when a page is blocked in managed mode
 // because it is not on any whitelist. It lets an authorized user preview the
 // blocked page, to decide later whether to manually allow it.
 class ManagedModeInterstitial : public content::InterstitialPageDelegate {
  public:
+  virtual ~ManagedModeInterstitial();

[Bernhard Bauer, 2014/04/25 11:10:18]

The destructor doesn't need to be public either. No one should ever get a
pointer to this class :)

[Marc Treib, 2014/04/25 12:02:19]

Done. Good point!

+
+  static void Show(content::WebContents* web_contents,
+                   const GURL& url,
+                   const base::Callback<void(bool)>& callback);
+
+ private:
   ManagedModeInterstitial(content::WebContents* web_contents,
                           const GURL& url,
                           const base::Callback<void(bool)>& callback);
-  virtual ~ManagedModeInterstitial();
 
- private:
+  bool Init();
+
   // InterstitialPageDelegate implementation.
   virtual std::string GetHTMLContents() OVERRIDE;
   virtual void CommandReceived(const std::string& command) OVERRIDE;
   virtual void OnProceed() OVERRIDE;
   virtual void OnDontProceed() OVERRIDE;
 
   // Returns whether the blocked URL is now allowed. Called initially before the
   // interstitial is shown (to catch race conditions), or when the URL filtering
   // prefs change.
   bool ShouldProceed();
@@ skipping 11 matching lines @@
   // The UI language. Used for formatting the URL for display.
   std::string languages_;
   GURL url_;
 
   base::Callback<void(bool)> callback_;
 
   DISALLOW_COPY_AND_ASSIGN(ManagedModeInterstitial);
 };
 
 #endif  // CHROME_BROWSER_MANAGED_MODE_MANAGED_MODE_INTERSTITIAL_H_