Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Side by Side Diff: chrome/browser/managed_mode/managed_mode_interstitial.h

Issue 250803004: Cleanup: Refactor ManagedModeInterstitial to not "delete this" in the ctor. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Review comments. Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | chrome/browser/managed_mode/managed_mode_interstitial.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_MANAGED_MODE_MANAGED_MODE_INTERSTITIAL_H_ 5 #ifndef CHROME_BROWSER_MANAGED_MODE_MANAGED_MODE_INTERSTITIAL_H_
6 #define CHROME_BROWSER_MANAGED_MODE_MANAGED_MODE_INTERSTITIAL_H_ 6 #define CHROME_BROWSER_MANAGED_MODE_MANAGED_MODE_INTERSTITIAL_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/callback.h" 10 #include "base/callback.h"
11 #include "base/compiler_specific.h" 11 #include "base/compiler_specific.h"
12 #include "base/prefs/pref_change_registrar.h" 12 #include "base/prefs/pref_change_registrar.h"
13 #include "content/public/browser/interstitial_page_delegate.h" 13 #include "content/public/browser/interstitial_page_delegate.h"
14 #include "url/gurl.h" 14 #include "url/gurl.h"
15 15
16 namespace content { 16 namespace content {
17 class InterstitialPage; 17 class InterstitialPage;
18 class WebContents; 18 class WebContents;
19 } 19 }
20 20
21 // Delegate for an interstitial page when a page is blocked in managed mode 21 // Delegate for an interstitial page when a page is blocked in managed mode
22 // because it is not on any whitelist. It lets an authorized user preview the 22 // because it is not on any whitelist. It lets an authorized user preview the
23 // blocked page, to decide later whether to manually allow it. 23 // blocked page, to decide later whether to manually allow it.
24 class ManagedModeInterstitial : public content::InterstitialPageDelegate { 24 class ManagedModeInterstitial : public content::InterstitialPageDelegate {
25 public: 25 public:
26 static void Show(content::WebContents* web_contents,
27 const GURL& url,
28 const base::Callback<void(bool)>& callback);
29
30 private:
26 ManagedModeInterstitial(content::WebContents* web_contents, 31 ManagedModeInterstitial(content::WebContents* web_contents,
27 const GURL& url, 32 const GURL& url,
28 const base::Callback<void(bool)>& callback); 33 const base::Callback<void(bool)>& callback);
29 virtual ~ManagedModeInterstitial(); 34 virtual ~ManagedModeInterstitial();
30 35
31 private: 36 bool Init();
37
32 // InterstitialPageDelegate implementation. 38 // InterstitialPageDelegate implementation.
33 virtual std::string GetHTMLContents() OVERRIDE; 39 virtual std::string GetHTMLContents() OVERRIDE;
34 virtual void CommandReceived(const std::string& command) OVERRIDE; 40 virtual void CommandReceived(const std::string& command) OVERRIDE;
35 virtual void OnProceed() OVERRIDE; 41 virtual void OnProceed() OVERRIDE;
36 virtual void OnDontProceed() OVERRIDE; 42 virtual void OnDontProceed() OVERRIDE;
37 43
38 // Returns whether the blocked URL is now allowed. Called initially before the 44 // Returns whether the blocked URL is now allowed. Called initially before the
39 // interstitial is shown (to catch race conditions), or when the URL filtering 45 // interstitial is shown (to catch race conditions), or when the URL filtering
40 // prefs change. 46 // prefs change.
41 bool ShouldProceed(); 47 bool ShouldProceed();
(...skipping 11 matching lines...) Expand all
53 // The UI language. Used for formatting the URL for display. 59 // The UI language. Used for formatting the URL for display.
54 std::string languages_; 60 std::string languages_;
55 GURL url_; 61 GURL url_;
56 62
57 base::Callback<void(bool)> callback_; 63 base::Callback<void(bool)> callback_;
58 64
59 DISALLOW_COPY_AND_ASSIGN(ManagedModeInterstitial); 65 DISALLOW_COPY_AND_ASSIGN(ManagedModeInterstitial);
60 }; 66 };
61 67
62 #endif // CHROME_BROWSER_MANAGED_MODE_MANAGED_MODE_INTERSTITIAL_H_ 68 #endif // CHROME_BROWSER_MANAGED_MODE_MANAGED_MODE_INTERSTITIAL_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/managed_mode/managed_mode_interstitial.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698