Fix painting background for composited table cells in a non-composited row.

third_party/WebKit/Source/core/paint/TablePaintInvalidator.cpp

Index: third_party/WebKit/Source/core/paint/TablePaintInvalidator.cpp
diff --git a/third_party/WebKit/Source/core/paint/TablePaintInvalidator.cpp b/third_party/WebKit/Source/core/paint/TablePaintInvalidator.cpp
index 83b770615fdf4e52e4ad12b30e70ad62e6f4f394..6df57982c14b80664cc92c39cbaf33e60582b1ca 100644
--- a/third_party/WebKit/Source/core/paint/TablePaintInvalidator.cpp
+++ b/third_party/WebKit/Source/core/paint/TablePaintInvalidator.cpp
@@ -80,10 +80,18 @@ PaintInvalidationReason TablePaintInvalidator::invalidatePaintIfNeeded() {
           }
         }
         if ((!invalidated || row->hasSelfPaintingLayer()) &&
-            row->backgroundChangedSinceLastPaintInvalidation())
-          ObjectPaintInvalidator(*row)
+            row->backgroundChangedSinceLastPaintInvalidation()) {
+          ObjectPaintInvalidator invalidator(*row);
+          invalidator
               .slowSetPaintingLayerNeedsRepaintAndInvalidateDisplayItemClient(
                   *cell, PaintInvalidationStyleChange);
+          if (cell->usesCompositedCellDisplayItemClients()) {
+            cell->createCompositedCellDisplayItemClients();

[wkorman, 2016/11/16 20:15:46]

I've punted on using mutable or getMutableForPainting() in the interest of time
and since it's only this one call now. If you feel strongly I can rework.

[Xianzhu, 2016/11/16 20:39:03]

This can be simplified if you have
LayoutTableCell::backgroundDisplayItemClient():

 cell->ensureIsReadyForPaintInvalidation();
 ObjectPaintInvalidator(*row)
    .slowSetPaintLayerNeedsRepaintAndInvalidateDisplayItemClient(
        cell->backgroundDisplayItemClient(), PaintInvalidaitonStyleChange);

And you can also replace the other "*cell" parameters to
"cell->backgroundDisplayItemClient()" to increase the coverage of failing cases
(e.g. composited cell on background change of section, in case that the row is
not composited).

[wkorman, 2016/11/16 21:42:45]

Done.

+            invalidator.invalidateDisplayItemClient(
+                *cell->rowBackgroundDisplayItemClient(),
+                PaintInvalidationStyleChange);
+          }
+        }
       }
     }
   }