Fix painting background for composited table cells in a non-composited row.

third_party/WebKit/Source/core/paint/TablePaintInvalidator.cpp

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/paint/TablePaintInvalidator.h"
 
 #include "core/layout/LayoutTable.h"
 #include "core/layout/LayoutTableCell.h"
 #include "core/layout/LayoutTableCol.h"
 #include "core/layout/LayoutTableRow.h"
@@ skipping 62 matching lines @@
                columnGroup->backgroundChangedSinceLastPaintInvalidation()) ||
               (column &&
                column->backgroundChangedSinceLastPaintInvalidation())) {
             sectionInvalidator
                 .slowSetPaintingLayerNeedsRepaintAndInvalidateDisplayItemClient(
                     *cell, PaintInvalidationStyleChange);
             invalidated = true;
           }
         }
         if ((!invalidated || row->hasSelfPaintingLayer()) &&
-            row->backgroundChangedSinceLastPaintInvalidation())
-          ObjectPaintInvalidator(*row)
+            row->backgroundChangedSinceLastPaintInvalidation()) {
+          ObjectPaintInvalidator invalidator(*row);
+          invalidator
               .slowSetPaintingLayerNeedsRepaintAndInvalidateDisplayItemClient(
                   *cell, PaintInvalidationStyleChange);
+          if (cell->usesCompositedCellDisplayItemClients()) {
+            cell->createCompositedCellDisplayItemClients();

[wkorman, 2016/11/16 20:15:46]

I've punted on using mutable or getMutableForPainting() in the interest of time
and since it's only this one call now. If you feel strongly I can rework.

[Xianzhu, 2016/11/16 20:39:03]

This can be simplified if you have
LayoutTableCell::backgroundDisplayItemClient():

 cell->ensureIsReadyForPaintInvalidation();
 ObjectPaintInvalidator(*row)
    .slowSetPaintLayerNeedsRepaintAndInvalidateDisplayItemClient(
        cell->backgroundDisplayItemClient(), PaintInvalidaitonStyleChange);

And you can also replace the other "*cell" parameters to
"cell->backgroundDisplayItemClient()" to increase the coverage of failing cases
(e.g. composited cell on background change of section, in case that the row is
not composited).

[wkorman, 2016/11/16 21:42:45]

Done.

+            invalidator.invalidateDisplayItemClient(
+                *cell->rowBackgroundDisplayItemClient(),
+                PaintInvalidationStyleChange);
+          }
+        }
       }
     }
   }
 
   return reason;
 }
 
 }  // namespace blink