Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1117)

Unified Diff: third_party/WebKit/Source/core/paint/TableCellPainter.cpp

Issue 2507893002: Fix painting background for composited table cells in a non-composited row. (Closed)
Patch Set: Add test expectations. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/paint/TableCellPainter.cpp
diff --git a/third_party/WebKit/Source/core/paint/TableCellPainter.cpp b/third_party/WebKit/Source/core/paint/TableCellPainter.cpp
index 2fc5973ee3b9f7a2d94a19dc07925adb6f5f3e76..e7bf05f4534ef3740dddd54c09442be3abd89ece 100644
--- a/third_party/WebKit/Source/core/paint/TableCellPainter.cpp
+++ b/third_party/WebKit/Source/core/paint/TableCellPainter.cpp
@@ -71,12 +71,20 @@ static EBorderStyle collapsedBorderStyle(EBorderStyle style) {
const DisplayItemClient& TableCellPainter::displayItemClientForBorders() const {
// TODO(wkorman): We may need to handle PaintInvalidationDelayedFull.
// http://crbug.com/657186
- return m_layoutTableCell.usesTableAsAdditionalDisplayItemClient()
+ return m_layoutTableCell.usesCompositedCellDisplayItemClients()
? static_cast<const DisplayItemClient&>(
*m_layoutTableCell.collapsedBorderValues())
: m_layoutTableCell;
}
+const DisplayItemClient& TableCellPainter::displayItemClientForBackground()
+ const {
+ return m_layoutTableCell.usesCompositedCellDisplayItemClients()
+ ? static_cast<const DisplayItemClient&>(
+ *m_layoutTableCell.rowBackgroundDisplayItemClient())
+ : m_layoutTableCell;
+}
+
void TableCellPainter::paintCollapsedBorders(
const PaintInfo& paintInfo,
const LayoutPoint& paintOffset,
@@ -195,14 +203,15 @@ void TableCellPainter::paintContainerBackgroundBehindCell(
!m_layoutTableCell.firstChild())
return;
- if (LayoutObjectDrawingRecorder::useCachedDrawingIfPossible(
- paintInfo.context, m_layoutTableCell, type))
+ const DisplayItemClient& client = displayItemClientForBackground();
+ if (DrawingRecorder::useCachedDrawingIfPossible(paintInfo.context, client,
+ type))
return;
LayoutRect paintRect =
paintRectNotIncludingVisualOverflow(adjustedPaintOffset);
- LayoutObjectDrawingRecorder recorder(paintInfo.context, m_layoutTableCell,
- type, paintRect);
+ DrawingRecorder recorder(paintInfo.context, client, type,
+ FloatRect(paintRect));
paintBackground(paintInfo, paintRect, backgroundObject);
}

Powered by Google App Engine
This is Rietveld 408576698