In rebaseline-cl, don't check for local file existence.

In rebaseline-cl, don't check for local file existence.

I originally added filtering of tests to only include files that exist
locally in http://crrev.com/2371803003.

But now, it seems clearer that this was the wrong choice, since:

 1. Virtual tests don't exist on the local file system
 2. When --issue is passed (when downloading baselines for try jobs
    on another CL), the files don't exist locally.

In order to stop checking for file existence, another little issue
needed to be solved, which was that when getting the list of files
that were changed, the list included deleted files, which we don't
want to rebaseline; so this CL also fixes that.

BUG=663411, 656154, 649691
Committed: https://crrev.com/daf1ddbd71f55b0765611a7273c74860dbd3d6b2
Cr-Commit-Position: refs/heads/master@{#432548}

[qyearsley, 2016-11-16 00:44:59]

qyearsley@chromium.org changed reviewers:
+ dpranke@chromium.org, wkorman@chromium.org

[Dirk Pranke, 2016-11-16 01:11:14]

lgtm.

You have a bad link to the prior CL in your description.

[qyearsley, 2016-11-16 16:39:47]

Description was changed from

==========
In rebaseline-cl, don't check for local file existence.

I originally added filtering of tests to only include files that exist
locally in http://crbug.com/2371803003.

But now, it seems clearer that this was the wrong choice, since:

 1. Virtual tests don't exist on the local file system
 2. When --issue is passed (when downloading baselines for try jobs
    on another CL), the files don't exist locally.

In order to stop checking for file existence, another little issue
needed to be solved, which was that when getting the list of files
that were changed, the list included deleted files, which we don't
want to rebaseline; so this CL also fixes that.

BUG=663411,656154,649691
==========

to

==========
In rebaseline-cl, don't check for local file existence.

I originally added filtering of tests to only include files that exist
locally in http://crrev.com/2371803003.

But now, it seems clearer that this was the wrong choice, since:

 1. Virtual tests don't exist on the local file system
 2. When --issue is passed (when downloading baselines for try jobs
    on another CL), the files don't exist locally.

In order to stop checking for file existence, another little issue
needed to be solved, which was that when getting the list of files
that were changed, the list included deleted files, which we don't
want to rebaseline; so this CL also fixes that.

BUG=663411,656154,649691
==========

[qyearsley, 2016-11-16 16:40:30]

On 2016/11/16 at 01:11:14, dpranke wrote:
> lgtm.
> 
> You have a bad link to the prior CL in your description.

Darn. Now fixed.

[qyearsley, 2016-11-16 16:40:33]

The CQ bit was checked by qyearsley@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-16 16:41:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[qyearsley, 2016-11-16 17:44:18]

The CQ bit was unchecked by qyearsley@chromium.org

[qyearsley, 2016-11-16 17:44:20]

The CQ bit was checked by qyearsley@chromium.org

[commit-bot: I haz the power, 2016-11-16 17:44:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-16 17:52:31]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-11-16 18:20:02]

Description was changed from

==========
In rebaseline-cl, don't check for local file existence.

I originally added filtering of tests to only include files that exist
locally in http://crrev.com/2371803003.

But now, it seems clearer that this was the wrong choice, since:

 1. Virtual tests don't exist on the local file system
 2. When --issue is passed (when downloading baselines for try jobs
    on another CL), the files don't exist locally.

In order to stop checking for file existence, another little issue
needed to be solved, which was that when getting the list of files
that were changed, the list included deleted files, which we don't
want to rebaseline; so this CL also fixes that.

BUG=663411,656154,649691
==========

to

==========
In rebaseline-cl, don't check for local file existence.

I originally added filtering of tests to only include files that exist
locally in http://crrev.com/2371803003.

But now, it seems clearer that this was the wrong choice, since:

 1. Virtual tests don't exist on the local file system
 2. When --issue is passed (when downloading baselines for try jobs
    on another CL), the files don't exist locally.

In order to stop checking for file existence, another little issue
needed to be solved, which was that when getting the list of files
that were changed, the list included deleted files, which we don't
want to rebaseline; so this CL also fixes that.

BUG=663411,656154,649691

Committed: https://crrev.com/daf1ddbd71f55b0765611a7273c74860dbd3d6b2
Cr-Commit-Position: refs/heads/master@{#432548}
==========

[commit-bot: I haz the power, 2016-11-16 18:20:03]

Patchset 1 (id:??) landed as
https://crrev.com/daf1ddbd71f55b0765611a7273c74860dbd3d6b2
Cr-Commit-Position: refs/heads/master@{#432548}