Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl.py

Issue 2507613002: In rebaseline-cl, don't check for local file existence. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl.py b/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl.py
index 2f169e4141fd3dbfed0badfea55e338e39620264..5ef70e6a24f2f110927aab4179a7cf18f726dd50 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl.py
@@ -15,7 +15,6 @@ import optparse
from webkitpy.common.net.rietveld import Rietveld
from webkitpy.common.net.web import Web
from webkitpy.common.net.git_cl import GitCL
-from webkitpy.common.webkit_finder import WebKitFinder
from webkitpy.layout_tests.models.test_expectations import BASELINE_SUFFIX_LIST
from webkitpy.tool.commands.rebaseline import AbstractParallelRebaselineCommand
@@ -73,28 +72,12 @@ class RebaselineCL(AbstractParallelRebaselineCommand):
test_prefix_list = self._test_prefix_list(
issue_number, only_changed_tests=options.only_changed_tests)
- # TODO(qyearsley): Fix places where non-existing tests may be added:
- # 1. Make sure that the tests obtained when passing --only-changed-tests include only existing tests.
- test_prefix_list = self._filter_existing(test_prefix_list)
-
self._log_test_prefix_list(test_prefix_list)
if options.dry_run:
return
self.rebaseline(options, test_prefix_list)
- def _filter_existing(self, test_prefix_list):
- """Filters out entries in |test_prefix_list| for tests that don't exist."""
- new_test_prefix_list = {}
- port = self._tool.port_factory.get()
- for test in test_prefix_list:
- path = port.abspath_for_test(test)
- if self._tool.filesystem.exists(path):
- new_test_prefix_list[test] = test_prefix_list[test]
- else:
- _log.warning('%s not found, removing from list.', path)
- return new_test_prefix_list
-
def _get_issue_number(self, options):
"""Gets the Rietveld CL number from either |options| or from the current local branch."""
if options.issue:

Powered by Google App Engine
This is Rietveld 408576698