Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(793)

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/common/net/rietveld.py

Issue 2507613002: In rebaseline-cl, don't check for local file existence. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Tools/Scripts/webkitpy/common/net/rietveld_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Tools/Scripts/webkitpy/common/net/rietveld.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/common/net/rietveld.py b/third_party/WebKit/Tools/Scripts/webkitpy/common/net/rietveld.py
index ba4ef1ef5c0e4505819f7118c75f13bb0f6bc1ed..abc9c5d6ef0550315fe8d865d17899edb956cf27 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/common/net/rietveld.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/common/net/rietveld.py
@@ -77,14 +77,14 @@ class Rietveld(object):
return sorted(builder_to_latest_build.values())
def changed_files(self, issue_number):
- """Lists the files included in a CL, or None if this can't be determined.
+ """Lists the files included in a CL that are changed but not deleted.
File paths are sorted and relative to the repository root.
"""
try:
url = self._latest_patchset_url(issue_number)
issue_data = self._get_json(url)
- return sorted(issue_data['files'])
+ return sorted(path for path, file_change in issue_data['files'].iteritems() if file_change['status'] != 'D')
except (urllib2.URLError, ValueError, KeyError):
_log.warning('Failed to list changed files for issue %s.', issue_number)
return None
« no previous file with comments | « no previous file | third_party/WebKit/Tools/Scripts/webkitpy/common/net/rietveld_unittest.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698