Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 250733007: Revert of Refactor SkPictureStateTree::Iterator to avoid use of kClip_SaveFlag. (Closed)

Created:
6 years, 8 months ago by bsalomon
Modified:
6 years, 8 months ago
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Revert of Refactor SkPictureStateTree::Iterator to avoid use of kClip_SaveFlag. (https://codereview.chromium.org/246893005/) Reason for revert: https://code.google.com/p/chromium/issues/detail?id=366889 Original issue's description: > Refactor SkPictureStateTree::Iterator to avoid use of kClip_SaveFlag. > > The current implementation relies on soon-to-be-deprecated > kClip_SaveFlag behavior. Updated to use default save flags > (kMatrixClip_SaveFlag) and stop assuming that the matrix survives > restore() calls. > > R=junov@chromium.org,robertphillips@chromium.org,reed@google.com > > Committed: http://code.google.com/p/skia/source/detail?r=14319 TBR=junov@chromium.org,reed@google.com,robertphillips@chromium.org,robertphillips@google.com,fmalita@chromium.org NOTREECHECKS=true NOTRY=true Committed: http://code.google.com/p/skia/source/detail?r=14383

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -47 lines) Patch
M src/core/SkPicturePlayback.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M src/core/SkPictureStateTree.h View 2 chunks +2 lines, -6 lines 0 comments Download
M src/core/SkPictureStateTree.cpp View 4 chunks +28 lines, -38 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
bsalomon
Created Revert of Refactor SkPictureStateTree::Iterator to avoid use of kClip_SaveFlag.
6 years, 8 months ago (2014-04-25 15:12:53 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/250733007/1
6 years, 8 months ago (2014-04-25 15:13:21 UTC) #2
commit-bot: I haz the power
6 years, 8 months ago (2014-04-25 15:13:32 UTC) #3
Message was sent while issue was closed.
Change committed as 14383

Powered by Google App Engine
This is Rietveld 408576698