Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(421)

Side by Side Diff: src/full-codegen/mips64/full-codegen-mips64.cc

Issue 2507143003: [ic] Pass globals' names to Runtime::kDeclareGlobals. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/full-codegen/mips/full-codegen-mips.cc ('k') | src/full-codegen/ppc/full-codegen-ppc.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_MIPS64 5 #if V8_TARGET_ARCH_MIPS64
6 6
7 // Note on Mips implementation: 7 // Note on Mips implementation:
8 // 8 //
9 // The result_register() for mips is the 'v0' register, which is defined 9 // The result_register() for mips is the 'v0' register, which is defined
10 // by the ABI to contain function return values. However, the first 10 // by the ABI to contain function return values. However, the first
(...skipping 763 matching lines...) Expand 10 before | Expand all | Expand 10 after
774 } 774 }
775 775
776 776
777 void FullCodeGenerator::VisitVariableDeclaration( 777 void FullCodeGenerator::VisitVariableDeclaration(
778 VariableDeclaration* declaration) { 778 VariableDeclaration* declaration) {
779 VariableProxy* proxy = declaration->proxy(); 779 VariableProxy* proxy = declaration->proxy();
780 Variable* variable = proxy->var(); 780 Variable* variable = proxy->var();
781 switch (variable->location()) { 781 switch (variable->location()) {
782 case VariableLocation::UNALLOCATED: { 782 case VariableLocation::UNALLOCATED: {
783 DCHECK(!variable->binding_needs_init()); 783 DCHECK(!variable->binding_needs_init());
784 globals_->Add(variable->name(), zone());
784 FeedbackVectorSlot slot = proxy->VariableFeedbackSlot(); 785 FeedbackVectorSlot slot = proxy->VariableFeedbackSlot();
785 DCHECK(!slot.IsInvalid()); 786 DCHECK(!slot.IsInvalid());
786 globals_->Add(handle(Smi::FromInt(slot.ToInt()), isolate()), zone()); 787 globals_->Add(handle(Smi::FromInt(slot.ToInt()), isolate()), zone());
787 globals_->Add(isolate()->factory()->undefined_value(), zone()); 788 globals_->Add(isolate()->factory()->undefined_value(), zone());
788 break; 789 break;
789 } 790 }
790 case VariableLocation::PARAMETER: 791 case VariableLocation::PARAMETER:
791 case VariableLocation::LOCAL: 792 case VariableLocation::LOCAL:
792 if (variable->binding_needs_init()) { 793 if (variable->binding_needs_init()) {
793 Comment cmnt(masm_, "[ VariableDeclaration"); 794 Comment cmnt(masm_, "[ VariableDeclaration");
(...skipping 29 matching lines...) Expand all
823 } 824 }
824 } 825 }
825 826
826 827
827 void FullCodeGenerator::VisitFunctionDeclaration( 828 void FullCodeGenerator::VisitFunctionDeclaration(
828 FunctionDeclaration* declaration) { 829 FunctionDeclaration* declaration) {
829 VariableProxy* proxy = declaration->proxy(); 830 VariableProxy* proxy = declaration->proxy();
830 Variable* variable = proxy->var(); 831 Variable* variable = proxy->var();
831 switch (variable->location()) { 832 switch (variable->location()) {
832 case VariableLocation::UNALLOCATED: { 833 case VariableLocation::UNALLOCATED: {
834 globals_->Add(variable->name(), zone());
833 FeedbackVectorSlot slot = proxy->VariableFeedbackSlot(); 835 FeedbackVectorSlot slot = proxy->VariableFeedbackSlot();
834 DCHECK(!slot.IsInvalid()); 836 DCHECK(!slot.IsInvalid());
835 globals_->Add(handle(Smi::FromInt(slot.ToInt()), isolate()), zone()); 837 globals_->Add(handle(Smi::FromInt(slot.ToInt()), isolate()), zone());
836 Handle<SharedFunctionInfo> function = 838 Handle<SharedFunctionInfo> function =
837 Compiler::GetSharedFunctionInfo(declaration->fun(), script(), info_); 839 Compiler::GetSharedFunctionInfo(declaration->fun(), script(), info_);
838 // Check for stack-overflow exception. 840 // Check for stack-overflow exception.
839 if (function.is_null()) return SetStackOverflow(); 841 if (function.is_null()) return SetStackOverflow();
840 globals_->Add(function, zone()); 842 globals_->Add(function, zone());
841 break; 843 break;
842 } 844 }
(...skipping 2803 matching lines...) Expand 10 before | Expand all | Expand 10 after
3646 reinterpret_cast<uint64_t>( 3648 reinterpret_cast<uint64_t>(
3647 isolate->builtins()->OnStackReplacement()->entry())); 3649 isolate->builtins()->OnStackReplacement()->entry()));
3648 return ON_STACK_REPLACEMENT; 3650 return ON_STACK_REPLACEMENT;
3649 } 3651 }
3650 3652
3651 3653
3652 } // namespace internal 3654 } // namespace internal
3653 } // namespace v8 3655 } // namespace v8
3654 3656
3655 #endif // V8_TARGET_ARCH_MIPS64 3657 #endif // V8_TARGET_ARCH_MIPS64
OLDNEW
« no previous file with comments | « src/full-codegen/mips/full-codegen-mips.cc ('k') | src/full-codegen/ppc/full-codegen-ppc.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698