Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Unified Diff: third_party/WebKit/Source/web/WebFrame.cpp

Issue 2507023002: Support script modify iframe scrolling, marginWidth and marginHeight attr (Closed)
Patch Set: add fix for marginWidth and marginHeight Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/WebFrame.cpp
diff --git a/third_party/WebKit/Source/web/WebFrame.cpp b/third_party/WebKit/Source/web/WebFrame.cpp
index 79ce1ac6b9979b00595c6cfcf32f373238e62f1c..7a44cef8a72eac5561b95a34a163ee5025b431a9 100644
--- a/third_party/WebKit/Source/web/WebFrame.cpp
+++ b/third_party/WebKit/Source/web/WebFrame.cpp
@@ -5,6 +5,7 @@
#include "public/web/WebFrame.h"
#include "bindings/core/v8/WindowProxyManager.h"
+#include "core/HTMLNames.h"
#include "core/frame/FrameHost.h"
#include "core/frame/FrameView.h"
#include "core/frame/LocalFrame.h"
@@ -25,6 +26,8 @@
namespace blink {
+using namespace HTMLNames;
+
bool WebFrame::swap(WebFrame* frame) {
using std::swap;
Frame* oldFrame = toImplBase()->frame();
@@ -144,6 +147,18 @@ void WebFrame::setFrameOwnerProperties(
owner->setAllowFullscreen(properties.allowFullscreen);
owner->setCsp(properties.requiredCsp);
owner->setDelegatedpermissions(properties.delegatedPermissions);
+
+ Frame* frame = toImplBase()->frame();
+ DCHECK(frame);
+
+ if (frame->isLocalFrame()) {
bokan 2016/11/18 20:56:18 This logic is currently duplicated for Remote and
+ LocalFrame* localFrame = toLocalFrame(frame);
+ localFrame->document()->body()->setIntegralAttribute(
bokan 2016/11/18 20:56:18 We should only do each of these if the specific at
+ marginwidthAttr, properties.marginWidth);
+ localFrame->document()->body()->setIntegralAttribute(
+ marginheightAttr, properties.marginHeight);
+ localFrame->view()->setNeedsLayout();
+ }
}
WebFrame* WebFrame::opener() const {

Powered by Google App Engine
This is Rietveld 408576698