Support script modify iframe scrolling, marginWidth and marginHeight attr

third_party/WebKit/Source/web/WebFrame.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "public/web/WebFrame.h"
 
 #include "bindings/core/v8/WindowProxyManager.h"
+#include "core/HTMLNames.h"
 #include "core/frame/FrameHost.h"
 #include "core/frame/FrameView.h"
 #include "core/frame/LocalFrame.h"
 #include "core/frame/RemoteFrame.h"
 #include "core/html/HTMLFrameElementBase.h"
 #include "core/html/HTMLFrameOwnerElement.h"
 #include "core/page/Page.h"
 #include "platform/UserGestureIndicator.h"
 #include "platform/heap/Handle.h"
 #include "public/web/WebElement.h"
 #include "public/web/WebFrameOwnerProperties.h"
 #include "public/web/WebSandboxFlags.h"
 #include "web/OpenedFrameTracker.h"
 #include "web/RemoteFrameOwner.h"
 #include "web/WebLocalFrameImpl.h"
 #include "web/WebRemoteFrameImpl.h"
 #include <algorithm>
 
 namespace blink {
 
+using namespace HTMLNames;
+
 bool WebFrame::swap(WebFrame* frame) {
   using std::swap;
   Frame* oldFrame = toImplBase()->frame();
   if (oldFrame->isDetaching())
     return false;
 
   // Unload the current Document in this frame: this calls unload handlers,
   // detaches child frames, etc. Since this runs script, make sure this frame
   // wasn't detached before continuing with the swap.
   // FIXME: There is no unit test for this condition, so one needs to be
@@ skipping 99 matching lines @@
   // At the moment, this is only used to replicate frame owner properties
   // for frames with a remote owner.
   RemoteFrameOwner* owner = toRemoteFrameOwner(toImplBase()->frame()->owner());
   DCHECK(owner);
   owner->setScrollingMode(properties.scrollingMode);
   owner->setMarginWidth(properties.marginWidth);
   owner->setMarginHeight(properties.marginHeight);
   owner->setAllowFullscreen(properties.allowFullscreen);
   owner->setCsp(properties.requiredCsp);
   owner->setDelegatedpermissions(properties.delegatedPermissions);
+
+  Frame* frame = toImplBase()->frame();
+  DCHECK(frame);
+
+  if (frame->isLocalFrame()) {

[bokan, 2016/11/18 20:56:18]

This logic is currently duplicated for Remote and Local frames. I think it'd be
better if we added

Document::didChangeFrameOwnerProperties(marginWidth, marginHeight, scrolling)

and called it from HTMLFrameOwnerBase::setScrollingMode|MarginWidth|MarginHeight
and here (before setting the RemoteFrameOwner properties so document can check
for differences and issue a layout if needed, for example).

+    LocalFrame* localFrame = toLocalFrame(frame);
+    localFrame->document()->body()->setIntegralAttribute(

[bokan, 2016/11/18 20:56:18]

We should only do each of these if the specific attribute changed.

+        marginwidthAttr, properties.marginWidth);
+    localFrame->document()->body()->setIntegralAttribute(
+        marginheightAttr, properties.marginHeight);
+    localFrame->view()->setNeedsLayout();
+  }
 }
 
 WebFrame* WebFrame::opener() const {
   return m_opener;
 }
 
 void WebFrame::setOpener(WebFrame* opener) {
   if (m_opener)
     m_opener->m_openedFrameTracker->remove(this);
   if (opener)
@@ skipping 168 matching lines @@
   void WebFrame::clearWeakFrames(VisitorDispatcher visitor) {              \
     clearWeakFramesImpl(visitor);                                          \
   }
 
 DEFINE_VISITOR_METHOD(Visitor*)
 DEFINE_VISITOR_METHOD(InlinedGlobalMarkingVisitor)
 
 #undef DEFINE_VISITOR_METHOD
 
 }  // namespace blink