Support script modify iframe scrolling, marginWidth and marginHeight attr

third_party/WebKit/Source/core/html/HTMLFrameElementBase.cpp

Index: third_party/WebKit/Source/core/html/HTMLFrameElementBase.cpp
diff --git a/third_party/WebKit/Source/core/html/HTMLFrameElementBase.cpp b/third_party/WebKit/Source/core/html/HTMLFrameElementBase.cpp
index eb81d639c4de017fbb4adf4c46265078a85c0f43..c31d903c50ad77a4ac2f093edb4a897330fecd8c 100644
--- a/third_party/WebKit/Source/core/html/HTMLFrameElementBase.cpp
+++ b/third_party/WebKit/Source/core/html/HTMLFrameElementBase.cpp
@@ -117,8 +117,16 @@ void HTMLFrameElementBase::openURL(bool replaceCurrentItem) {
 void HTMLFrameElementBase::frameOwnerPropertiesChanged() {
   // Don't notify about updates if contentFrame() is null, for example when
   // the subframe hasn't been created yet.
-  if (contentFrame())
+  if (contentFrame()) {
     document().frame()->loader().client()->didChangeFrameOwnerProperties(this);
+    if (contentFrame()->isLocalFrame()) {
+      contentDocument()->body()->setIntegralAttribute(marginwidthAttr,

[bokan, 2016/11/18 20:56:18]

These should be done inside setMarginWidth/setMarginHeight/setScrollingMode as
needed.

+                                                      m_marginWidth);
+      contentDocument()->body()->setIntegralAttribute(marginheightAttr,
+                                                      m_marginHeight);
+      toLocalFrame(contentFrame())->view()->setNeedsLayout();
+    }
+  }
 }
 
 void HTMLFrameElementBase::parseAttribute(const QualifiedName& name,
@@ -147,10 +155,8 @@ void HTMLFrameElementBase::parseAttribute(const QualifiedName& name,
     // conflicts and generate a unique frame name.
   } else if (name == marginwidthAttr) {
     setMarginWidth(value.toInt());
-    // FIXME: If we are already attached, this has no effect.
   } else if (name == marginheightAttr) {
     setMarginHeight(value.toInt());
-    // FIXME: If we are already attached, this has no effect.
   } else if (name == scrollingAttr) {
     // Auto and yes both simply mean "allow scrolling." No means "don't allow
     // scrolling."
@@ -158,7 +164,6 @@ void HTMLFrameElementBase::parseAttribute(const QualifiedName& name,
       setScrollingMode(ScrollbarAuto);
     else if (equalIgnoringCase(value, "no"))
       setScrollingMode(ScrollbarAlwaysOff);
-    // FIXME: If we are already attached, this has no effect.

[bokan, 2016/11/18 20:56:18]

What did these FIXMEs mean?

[chaopeng, 2016/11/18 21:25:03]

I think it means these 3 attributes doesnot support script modify cause these 3
attributes are only used for create child frame before. 

[bokan, 2016/11/18 21:37:03]

Hmm, I think it was to mean that calling this function after the frame has
attached to the document doesn't do anything (because they've already been
parsed). But given that it's 10+ years old and doesn't have any action
associated it's fine to remove. Please remove the ones left over above about
name not changing.

   } else if (name == onbeforeunloadAttr) {
     // FIXME: should <frame> elements have beforeunload handlers?
     setAttributeEventListener(
@@ -253,16 +258,25 @@ void HTMLFrameElementBase::defaultEventHandler(Event* event) {
 }
 
 void HTMLFrameElementBase::setScrollingMode(ScrollbarMode scrollbarMode) {
+  if (m_scrollingMode == scrollbarMode)
+    return;
+
   m_scrollingMode = scrollbarMode;
   frameOwnerPropertiesChanged();
 }
 
 void HTMLFrameElementBase::setMarginWidth(int marginWidth) {
+  if (m_marginWidth == marginWidth)
+    return;
+
   m_marginWidth = marginWidth;
   frameOwnerPropertiesChanged();
 }
 
 void HTMLFrameElementBase::setMarginHeight(int marginHeight) {
+  if (m_marginHeight == marginHeight)
+    return;
+
   m_marginHeight = marginHeight;
   frameOwnerPropertiesChanged();
 }