Support script modify iframe scrolling, marginWidth and marginHeight attr

third_party/WebKit/Source/core/html/HTMLFrameElementBase.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2000 Simon Hausmann (hausmann@kde.org)
  *           (C) 2001 Dirk Mueller (mueller@kde.org)
  * Copyright (C) 2004, 2006, 2008, 2009 Apple Inc. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
@@ skipping 99 matching lines @@
   if (contentFrame()->owner()->getSandboxFlags() & SandboxOrigin)
     return;
   toLocalFrame(contentFrame())
       ->script()
       .executeScriptIfJavaScriptURL(scriptURL, this);
 }
 
 void HTMLFrameElementBase::frameOwnerPropertiesChanged() {
   // Don't notify about updates if contentFrame() is null, for example when
   // the subframe hasn't been created yet.
-  if (contentFrame())
+  if (contentFrame()) {
     document().frame()->loader().client()->didChangeFrameOwnerProperties(this);
+    if (contentFrame()->isLocalFrame()) {
+      contentDocument()->body()->setIntegralAttribute(marginwidthAttr,

[bokan, 2016/11/18 20:56:18]

These should be done inside setMarginWidth/setMarginHeight/setScrollingMode as
needed.

+                                                      m_marginWidth);
+      contentDocument()->body()->setIntegralAttribute(marginheightAttr,
+                                                      m_marginHeight);
+      toLocalFrame(contentFrame())->view()->setNeedsLayout();
+    }
+  }
 }
 
 void HTMLFrameElementBase::parseAttribute(const QualifiedName& name,
                                           const AtomicString& oldValue,
                                           const AtomicString& value) {
   if (name == srcdocAttr) {
     if (!value.isNull()) {
       setLocation(srcdocURL().getString());
     } else {
       const AtomicString& srcValue = fastGetAttribute(srcAttr);
       if (!srcValue.isNull())
         setLocation(stripLeadingAndTrailingHTMLSpaces(srcValue));
     }
   } else if (name == srcAttr && !fastHasAttribute(srcdocAttr)) {
     setLocation(stripLeadingAndTrailingHTMLSpaces(value));
   } else if (name == idAttr) {
     // Important to call through to base for the id attribute so the hasID bit
     // gets set.
     HTMLFrameOwnerElement::parseAttribute(name, oldValue, value);
     m_frameName = value;
   } else if (name == nameAttr) {
     m_frameName = value;
     // FIXME: If we are already attached, this doesn't actually change the
     // frame's name.
     // FIXME: If we are already attached, this doesn't check for frame name
     // conflicts and generate a unique frame name.
   } else if (name == marginwidthAttr) {
     setMarginWidth(value.toInt());
-    // FIXME: If we are already attached, this has no effect.
   } else if (name == marginheightAttr) {
     setMarginHeight(value.toInt());
-    // FIXME: If we are already attached, this has no effect.
   } else if (name == scrollingAttr) {
     // Auto and yes both simply mean "allow scrolling." No means "don't allow
     // scrolling."
     if (equalIgnoringCase(value, "auto") || equalIgnoringCase(value, "yes"))
       setScrollingMode(ScrollbarAuto);
     else if (equalIgnoringCase(value, "no"))
       setScrollingMode(ScrollbarAlwaysOff);
-    // FIXME: If we are already attached, this has no effect.

[bokan, 2016/11/18 20:56:18]

What did these FIXMEs mean?

[chaopeng, 2016/11/18 21:25:03]

I think it means these 3 attributes doesnot support script modify cause these 3
attributes are only used for create child frame before. 

[bokan, 2016/11/18 21:37:03]

Hmm, I think it was to mean that calling this function after the frame has
attached to the document doesn't do anything (because they've already been
parsed). But given that it's 10+ years old and doesn't have any action
associated it's fine to remove. Please remove the ones left over above about
name not changing.

   } else if (name == onbeforeunloadAttr) {
     // FIXME: should <frame> elements have beforeunload handlers?
     setAttributeEventListener(
         EventTypeNames::beforeunload,
         createAttributeEventListener(this, name, value, eventParameterName()));
   } else {
     HTMLFrameOwnerElement::parseAttribute(name, oldValue, value);
   }
 }
 
@@ skipping 74 matching lines @@
 // process. See http://crbug.com/339659.
 void HTMLFrameElementBase::defaultEventHandler(Event* event) {
   if (contentFrame() && contentFrame()->isRemoteFrame()) {
     toRemoteFrame(contentFrame())->forwardInputEvent(event);
     return;
   }
   HTMLFrameOwnerElement::defaultEventHandler(event);
 }
 
 void HTMLFrameElementBase::setScrollingMode(ScrollbarMode scrollbarMode) {
+  if (m_scrollingMode == scrollbarMode)
+    return;
+
   m_scrollingMode = scrollbarMode;
   frameOwnerPropertiesChanged();
 }
 
 void HTMLFrameElementBase::setMarginWidth(int marginWidth) {
+  if (m_marginWidth == marginWidth)
+    return;
+
   m_marginWidth = marginWidth;
   frameOwnerPropertiesChanged();
 }
 
 void HTMLFrameElementBase::setMarginHeight(int marginHeight) {
+  if (m_marginHeight == marginHeight)
+    return;
+
   m_marginHeight = marginHeight;
   frameOwnerPropertiesChanged();
 }
 
 }  // namespace blink