Views/a11y: Only tag Views AX_STATE_FOCUSABLE if IsAccessibilityFocusable().

Views/a11y: Only tag Views AX_STATE_FOCUSABLE if IsAccessibilityFocusable().

Currently, all Views are tagged ui::AX_STATE_FOCUSABLE, regardless of their
return value from View::IsAccessibilityFocusable(). Start checking this before
adding this flag.

This change might break Views that haven't been tagged focusable when they
really should be.

Committed: https://crrev.com/a6a4656375d13ea45b1727a390f35f40cb637113
Cr-Commit-Position: refs/heads/master@{#433465}

[Patti Lor, 2016-11-15 00:37:43]

The CQ bit was checked by patricialor@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-15 00:38:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-15 02:37:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-15 02:37:15]

Dry run: This issue passed the CQ dry run.

[Patti Lor, 2016-11-15 02:39:53]

The CQ bit was checked by patricialor@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-15 02:46:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Patti Lor, 2016-11-15 04:18:02]

patricialor@chromium.org changed reviewers:
+ dmazzoni@chromium.org

[Patti Lor, 2016-11-15 04:18:02]

Hi dmazzoni, this is the part of the CL you suggested we let bake a bit longer
to catch regressions from https://codereview.chromium.org/2490073002/ - will
wait for m57.

[commit-bot: I haz the power, 2016-11-15 04:31:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-15 04:31:13]

Dry run: This issue passed the CQ dry run.

[dmazzoni, 2016-11-15 06:22:00]

dmazzoni@chromium.org changed reviewers:
+ dtseng@chromium.org, nektar@chromium.org

[dmazzoni, 2016-11-15 06:22:01]

lgtm in advance

Thanks!

@nektar and @dtseng FYI

[Patti Lor, 2016-11-20 23:58:23]

Hi dmazzoni - just an update before I commit this patch. We discussed this here:
https://codereview.chromium.org/2490073002/diff/60001/ui/views/accessibility/...
where I mentioned the possibility of reviewing all the View subclasses to see if
adding ui::AX_STATE_FOCUSABLE to their accessible state would be better than
letting problems be reported. Not sure if that is feasible since it looks like
there are 259 View subclasses according to cs.chromium.org, so just documenting
here that I haven't looked at any.

[Patti Lor, 2016-11-21 00:01:50]

The CQ bit was checked by patricialor@chromium.org

[commit-bot: I haz the power, 2016-11-21 00:02:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-21 00:56:04]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1479686510616180,
"parent_rev": ["a20694e78c2f174d545faafb8968541d23e89cdb", null], "commit_rev":
["a4f943e3691a26862f73406d5df9b37b44272b55", null]}

[commit-bot: I haz the power, 2016-11-21 00:56:31]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-21 00:58:35]

Description was changed from

==========
Views/a11y: Only tag Views AX_STATE_FOCUSABLE if IsAccessibilityFocusable().

Currently, all Views are tagged ui::AX_STATE_FOCUSABLE, regardless of their
return value from View::IsAccessibilityFocusable(). Start checking this before
adding this flag.

This change might break Views that haven't been tagged focusable when they
really should be.
==========

to

==========
Views/a11y: Only tag Views AX_STATE_FOCUSABLE if IsAccessibilityFocusable().

Currently, all Views are tagged ui::AX_STATE_FOCUSABLE, regardless of their
return value from View::IsAccessibilityFocusable(). Start checking this before
adding this flag.

This change might break Views that haven't been tagged focusable when they
really should be.

Committed: https://crrev.com/a6a4656375d13ea45b1727a390f35f40cb637113
Cr-Commit-Position: refs/heads/master@{#433465}
==========

[commit-bot: I haz the power, 2016-11-21 00:58:36]

Patchset 2 (id:??) landed as
https://crrev.com/a6a4656375d13ea45b1727a390f35f40cb637113
Cr-Commit-Position: refs/heads/master@{#433465}

[dmazzoni, 2016-11-21 04:54:19]

Thanks for the heads-up!  - Dominic