ui/views/accessibility/native_view_accessibility.cc - Issue 2506483002: Views/a11y: Only tag Views AX_STATE_FOCUSABLE if IsAccessibilityFocusable().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/accessibility/native_view_accessibility.cc

Issue 2506483002: Views/a11y: Only tag Views AX_STATE_FOCUSABLE if IsAccessibilityFocusable(). (Closed)

Patch Set: Add expectation. Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/views/accessibility/native_view_accessibility.cc

diff --git a/ui/views/accessibility/native_view_accessibility.cc b/ui/views/accessibility/native_view_accessibility.cc

index 04a0fa5afb95126235feb7432fb72ff02c50bf93..769442d7f87610640fc6a1aeba17498f650e2e9f 100644

--- a/ui/views/accessibility/native_view_accessibility.cc

+++ b/ui/views/accessibility/native_view_accessibility.cc

@@ -71,7 +71,8 @@ const ui::AXNodeData& NativeViewAccessibility::GetData() {

data_.AddStringAttribute(ui::AX_ATTR_DESCRIPTION,

base::UTF16ToUTF8(description));

- data_.state |= (1 << ui::AX_STATE_FOCUSABLE);

+ if (view_->IsAccessibilityFocusable())

+ data_.state |= (1 << ui::AX_STATE_FOCUSABLE);

if (!view_->enabled())

data_.state |= (1 << ui::AX_STATE_DISABLED);

« no previous file with comments | « no previous file | ui/views/accessibility/native_view_accessibility_unittest.cc » ('j') | no next file with comments »