MacViews/a11y: Allow accessibility clients to focus and unfocus focusable Views.

ui/views/accessibility/native_view_accessibility.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/accessibility/native_view_accessibility.h"
 
 #include "base/strings/utf_string_conversions.h"
 #include "build/build_config.h"
 #include "ui/accessibility/ax_action_data.h"
 #include "ui/accessibility/ax_node_data.h"
@@ skipping 53 matching lines @@
     return data_;
   }
 
   view_->GetAccessibleNodeData(&data_);
   data_.location = gfx::RectF(view_->GetBoundsInScreen());
   base::string16 description;
   view_->GetTooltipText(gfx::Point(), &description);
   data_.AddStringAttribute(ui::AX_ATTR_DESCRIPTION,
                            base::UTF16ToUTF8(description));
 
-  data_.state |= (1 << ui::AX_STATE_FOCUSABLE);
+  if (view_->IsAccessibilityFocusable())

[dmazzoni, 2016/11/14 23:13:37]

This is probably a good change, but just a warning
that it may break something. We made everything in
"views" focusable as a hack years ago when we switched
from native UI to views, because so many things were
not marked focusable that should have been.

I'm guessing we're in much better shape now, but
I wouldn't be surprised if a few things are not
marked focusable that should be.

Would it work to land without this change in M56,
then fix it as a follow-up in M57 so we have lots
of time to catch regressions?

[Patti Lor, 2016/11/15 04:13:35]

That sounds OK to me - either way it will be an improvement in the current
behaviour since it doesn't work at all at the moment. Have split out this change
into https://codereview.chromium.org/2506483002/ for now and won't try to land
this til after Nov 17, which seems to be when m56 splits off. Is there a way we
can pro-actively try and catch these cases instead of waiting for a bug to be
reported? e.g. go through all View subclasses, or something like that?

+    data_.state |= (1 << ui::AX_STATE_FOCUSABLE);
 
   if (!view_->enabled())
     data_.state |= (1 << ui::AX_STATE_DISABLED);
 
   if (!view_->visible())
     data_.state |= (1 << ui::AX_STATE_INVISIBLE);
 
   return data_;
 }
 
@@ skipping 125 matching lines @@
   action_data.value = new_value;
   action_data.action = clear_first ? ui::AX_ACTION_SET_VALUE
       : ui::AX_ACTION_REPLACE_SELECTED_TEXT;
   return view_->HandleAccessibleAction(action_data);
 }
 
 bool NativeViewAccessibility::CanSetStringValue() {
   return !ui::AXNodeData::IsFlagSet(GetData().state, ui::AX_STATE_READ_ONLY);
 }
 
+bool NativeViewAccessibility::SetFocused(bool focused) {
+  if (!ui::AXNodeData::IsFlagSet(GetData().state, ui::AX_STATE_FOCUSABLE))
+    return false;
+
+  if (focused)
+    view_->RequestFocus();
+  else if (view_->HasFocus())
+    view_->GetFocusManager()->ClearFocus();
+  return true;
+}
+
 void NativeViewAccessibility::OnWidgetDestroying(Widget* widget) {
   if (parent_widget_ == widget) {
     parent_widget_->RemoveObserver(this);
     parent_widget_ = nullptr;
   }
 }
 
 void NativeViewAccessibility::SetParentWidget(Widget* parent_widget) {
   if (parent_widget_)
     parent_widget_->RemoveObserver(this);
@@ skipping 30 matching lines @@
               child_widget_platform_node->GetDelegate());
       if (child_widget_view_accessibility->parent_widget() != widget)
         child_widget_view_accessibility->SetParentWidget(widget);
     }
 
     result_child_widgets->push_back(child_widget);
   }
 }
 
 }  // namespace views