Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Unified Diff: content/browser/frame_host/interstitial_page_impl.cc

Issue 2506183002: Make window.open() IPCs be frame-based (Closed)
Patch Set: Rebase. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/interstitial_page_impl.cc
diff --git a/content/browser/frame_host/interstitial_page_impl.cc b/content/browser/frame_host/interstitial_page_impl.cc
index d71195b4c9e2b16e9c7304fc003f322bca65f53a..66aab6fe288740ce21a9aa5c56e2443e3eea8ca9 100644
--- a/content/browser/frame_host/interstitial_page_impl.cc
+++ b/content/browser/frame_host/interstitial_page_impl.cc
@@ -733,18 +733,18 @@ void InterstitialPageImpl::DontCreateViewForTesting() {
void InterstitialPageImpl::CreateNewWindow(
SiteInstance* source_site_instance,
- int32_t route_id,
+ int32_t render_view_route_id,
int32_t main_frame_route_id,
int32_t main_frame_widget_route_id,
const mojom::CreateNewWindowParams& params,
SessionStorageNamespace* session_storage_namespace) {
- NOTREACHED() << "InterstitialPage does not support showing popups yet.";
+ NOTREACHED() << "InterstitialPage does not support showing popups.";
}
void InterstitialPageImpl::CreateNewWidget(int32_t render_process_id,
int32_t route_id,
blink::WebPopupType popup_type) {
- NOTREACHED() << "InterstitialPage does not support showing drop-downs yet.";
+ NOTREACHED() << "InterstitialPage does not support showing drop-downs.";
}
void InterstitialPageImpl::CreateNewFullscreenWidget(int32_t render_process_id,
@@ -754,17 +754,17 @@ void InterstitialPageImpl::CreateNewFullscreenWidget(int32_t render_process_id,
}
void InterstitialPageImpl::ShowCreatedWindow(int process_id,
- int route_id,
+ int main_frame_widget_route_id,
WindowOpenDisposition disposition,
const gfx::Rect& initial_rect,
bool user_gesture) {
- NOTREACHED() << "InterstitialPage does not support showing popups yet.";
+ NOTREACHED() << "InterstitialPage does not support showing popups.";
}
void InterstitialPageImpl::ShowCreatedWidget(int process_id,
int route_id,
const gfx::Rect& initial_rect) {
- NOTREACHED() << "InterstitialPage does not support showing drop-downs yet.";
+ NOTREACHED() << "InterstitialPage does not support showing drop-downs.";
}
void InterstitialPageImpl::ShowCreatedFullscreenWidget(int process_id,
« no previous file with comments | « content/browser/frame_host/interstitial_page_impl.h ('k') | content/browser/frame_host/render_frame_host_delegate.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698