Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Side by Side Diff: content/browser/frame_host/interstitial_page_impl.cc

Issue 2506183002: Make window.open() IPCs be frame-based (Closed)
Patch Set: Rebase. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/frame_host/interstitial_page_impl.h" 5 #include "content/browser/frame_host/interstitial_page_impl.h"
6 6
7 #include <utility> 7 #include <utility>
8 #include <vector> 8 #include <vector>
9 9
10 #include "base/bind.h" 10 #include "base/bind.h"
(...skipping 715 matching lines...) Expand 10 before | Expand all | Expand 10 after
726 InterstitialPageDelegate* InterstitialPageImpl::GetDelegateForTesting() { 726 InterstitialPageDelegate* InterstitialPageImpl::GetDelegateForTesting() {
727 return delegate_.get(); 727 return delegate_.get();
728 } 728 }
729 729
730 void InterstitialPageImpl::DontCreateViewForTesting() { 730 void InterstitialPageImpl::DontCreateViewForTesting() {
731 create_view_ = false; 731 create_view_ = false;
732 } 732 }
733 733
734 void InterstitialPageImpl::CreateNewWindow( 734 void InterstitialPageImpl::CreateNewWindow(
735 SiteInstance* source_site_instance, 735 SiteInstance* source_site_instance,
736 int32_t route_id, 736 int32_t render_view_route_id,
737 int32_t main_frame_route_id, 737 int32_t main_frame_route_id,
738 int32_t main_frame_widget_route_id, 738 int32_t main_frame_widget_route_id,
739 const mojom::CreateNewWindowParams& params, 739 const mojom::CreateNewWindowParams& params,
740 SessionStorageNamespace* session_storage_namespace) { 740 SessionStorageNamespace* session_storage_namespace) {
741 NOTREACHED() << "InterstitialPage does not support showing popups yet."; 741 NOTREACHED() << "InterstitialPage does not support showing popups.";
742 } 742 }
743 743
744 void InterstitialPageImpl::CreateNewWidget(int32_t render_process_id, 744 void InterstitialPageImpl::CreateNewWidget(int32_t render_process_id,
745 int32_t route_id, 745 int32_t route_id,
746 blink::WebPopupType popup_type) { 746 blink::WebPopupType popup_type) {
747 NOTREACHED() << "InterstitialPage does not support showing drop-downs yet."; 747 NOTREACHED() << "InterstitialPage does not support showing drop-downs.";
748 } 748 }
749 749
750 void InterstitialPageImpl::CreateNewFullscreenWidget(int32_t render_process_id, 750 void InterstitialPageImpl::CreateNewFullscreenWidget(int32_t render_process_id,
751 int32_t route_id) { 751 int32_t route_id) {
752 NOTREACHED() 752 NOTREACHED()
753 << "InterstitialPage does not support showing full screen popups."; 753 << "InterstitialPage does not support showing full screen popups.";
754 } 754 }
755 755
756 void InterstitialPageImpl::ShowCreatedWindow(int process_id, 756 void InterstitialPageImpl::ShowCreatedWindow(int process_id,
757 int route_id, 757 int main_frame_widget_route_id,
758 WindowOpenDisposition disposition, 758 WindowOpenDisposition disposition,
759 const gfx::Rect& initial_rect, 759 const gfx::Rect& initial_rect,
760 bool user_gesture) { 760 bool user_gesture) {
761 NOTREACHED() << "InterstitialPage does not support showing popups yet."; 761 NOTREACHED() << "InterstitialPage does not support showing popups.";
762 } 762 }
763 763
764 void InterstitialPageImpl::ShowCreatedWidget(int process_id, 764 void InterstitialPageImpl::ShowCreatedWidget(int process_id,
765 int route_id, 765 int route_id,
766 const gfx::Rect& initial_rect) { 766 const gfx::Rect& initial_rect) {
767 NOTREACHED() << "InterstitialPage does not support showing drop-downs yet."; 767 NOTREACHED() << "InterstitialPage does not support showing drop-downs.";
768 } 768 }
769 769
770 void InterstitialPageImpl::ShowCreatedFullscreenWidget(int process_id, 770 void InterstitialPageImpl::ShowCreatedFullscreenWidget(int process_id,
771 int route_id) { 771 int route_id) {
772 NOTREACHED() 772 NOTREACHED()
773 << "InterstitialPage does not support showing full screen popups."; 773 << "InterstitialPage does not support showing full screen popups.";
774 } 774 }
775 775
776 SessionStorageNamespace* InterstitialPageImpl::GetSessionStorageNamespace( 776 SessionStorageNamespace* InterstitialPageImpl::GetSessionStorageNamespace(
777 SiteInstance* instance) { 777 SiteInstance* instance) {
(...skipping 178 matching lines...) Expand 10 before | Expand all | Expand 10 after
956 void InterstitialPageImpl::UpdateDeviceScaleFactor(double device_scale_factor) { 956 void InterstitialPageImpl::UpdateDeviceScaleFactor(double device_scale_factor) {
957 WebContentsImpl* web_contents_impl = 957 WebContentsImpl* web_contents_impl =
958 static_cast<WebContentsImpl*>(web_contents_); 958 static_cast<WebContentsImpl*>(web_contents_);
959 if (!web_contents_impl) 959 if (!web_contents_impl)
960 return; 960 return;
961 961
962 web_contents_impl->UpdateDeviceScaleFactor(device_scale_factor); 962 web_contents_impl->UpdateDeviceScaleFactor(device_scale_factor);
963 } 963 }
964 964
965 } // namespace content 965 } // namespace content
OLDNEW
« no previous file with comments | « content/browser/frame_host/interstitial_page_impl.h ('k') | content/browser/frame_host/render_frame_host_delegate.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698