Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(808)

Unified Diff: content/browser/frame_host/interstitial_page_impl.h

Issue 2506183002: Make window.open() IPCs be frame-based (Closed)
Patch Set: Rebase. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/interstitial_page_impl.h
diff --git a/content/browser/frame_host/interstitial_page_impl.h b/content/browser/frame_host/interstitial_page_impl.h
index 777917ba3b732a5ac9c7bb7bdf2ff5509e32a039..aaf77bb5bdeac36e944ee23a4d672c7aed97e901 100644
--- a/content/browser/frame_host/interstitial_page_impl.h
+++ b/content/browser/frame_host/interstitial_page_impl.h
@@ -114,6 +114,18 @@ class CONTENT_EXPORT InterstitialPageImpl
void Copy() override;
void Paste() override;
void SelectAll() override;
+ void CreateNewWindow(
+ SiteInstance* source_site_instance,
+ int32_t render_view_route_id,
+ int32_t main_frame_route_id,
+ int32_t main_frame_widget_route_id,
+ const mojom::CreateNewWindowParams& params,
+ SessionStorageNamespace* session_storage_namespace) override;
+ void ShowCreatedWindow(int process_id,
+ int main_frame_widget_route_id,
+ WindowOpenDisposition disposition,
+ const gfx::Rect& initial_rect,
+ bool user_gesture) override;
// RenderViewHostDelegate implementation:
RenderViewHostDelegateView* GetDelegateView() override;
@@ -125,23 +137,11 @@ class CONTENT_EXPORT InterstitialPageImpl
int error_code) override;
RendererPreferences GetRendererPrefs(
BrowserContext* browser_context) const override;
- void CreateNewWindow(
- SiteInstance* source_site_instance,
- int32_t route_id,
- int32_t main_frame_route_id,
- int32_t main_frame_widget_route_id,
- const mojom::CreateNewWindowParams& params,
- SessionStorageNamespace* session_storage_namespace) override;
void CreateNewWidget(int32_t render_process_id,
int32_t route_id,
blink::WebPopupType popup_type) override;
void CreateNewFullscreenWidget(int32_t render_process_id,
int32_t route_id) override;
- void ShowCreatedWindow(int process_id,
- int route_id,
- WindowOpenDisposition disposition,
- const gfx::Rect& initial_rect,
- bool user_gesture) override;
void ShowCreatedWidget(int process_id,
int route_id,
const gfx::Rect& initial_rect) override;
« no previous file with comments | « chromecast/browser/cast_content_browser_client.cc ('k') | content/browser/frame_host/interstitial_page_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698