Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1368)

Unified Diff: content/public/browser/content_browser_client.h

Issue 2506183002: Make window.open() IPCs be frame-based (Closed)
Patch Set: Compile fix. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/browser/content_browser_client.h
diff --git a/content/public/browser/content_browser_client.h b/content/public/browser/content_browser_client.h
index 9d1756dec89cfc08ab87e015aae4ddf86b281c50..21b35f4c651bbcef95b8f29d06c56b50c85c0963 100644
--- a/content/public/browser/content_browser_client.h
+++ b/content/public/browser/content_browser_client.h
@@ -498,7 +498,9 @@ class CONTENT_EXPORT ContentBrowserClient {
// type. If true is returned, |no_javascript_access| will indicate whether
// the window that is created should be scriptable/in the same process.
// This is called on the IO thread.
- virtual bool CanCreateWindow(const GURL& opener_url,
+ virtual bool CanCreateWindow(int opener_render_process_id,
+ int opener_render_frame_id,
+ const GURL& opener_url,
const GURL& opener_top_level_frame_url,
const GURL& source_origin,
WindowContainerType container_type,
@@ -510,9 +512,6 @@ class CONTENT_EXPORT ContentBrowserClient {
bool user_gesture,
bool opener_suppressed,
ResourceContext* context,
- int render_process_id,
- int opener_render_view_id,
- int opener_render_frame_id,
bool* no_javascript_access);
// Notifies the embedder that the ResourceDispatcherHost has been created.

Powered by Google App Engine
This is Rietveld 408576698